fix(developer): reconnect --full-test in kmcmplib build and enable for CI
#12631
Conversation
…r CI The --full-test parameter in kmcmplib build.sh has not been working. This PR reconnects the parameter and also enables it by default for CI test builds (not release builds). Fixes: #12623
github-actions
bot
added
developer/
common/
developer/compilers/
common/resources/
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
changed the title
--full-test in kmcmplib build and enable for CI
|
Linux wasm build failed with: mac wasm build failed with:
mac arch build failed with: 0x00a is Invalid Token. Turns out that those lines both have a U+2002 at the end, which in WASM and VC++ builds is trimmed by |
| # mainline branch test, or as a release build | ||
| # | ||
| builder_is_ci_build() { | ||
| if builder_is_ci_release_build || builder_is_ci_test_build; then |
There was a problem hiding this comment.
Do some build configs use a --ci flag?
There was a problem hiding this comment.
They do at present. We'll move away from that in the future, because it should be unnecessary. Similarly, web and iOS have a ci.sh which is just different to everything else (there's quite a lot of stuff in the web build scripts which has diverged from the other platforms -- we should be able to simplify). (web scripts also do other tests for CI environments which should be updated to use these functions in the future)
Those changes can wait until 19.0, however.
While kmc did this already in its callbacks, the unit test callbacks did not, which meant that some keyboard tests failed on Linux and macOS. Relates-to: #12623
…hitespace management On mac arch build, kmcmplib is failing to trim U+2002, unlike all other platforms. Using UTF-8 locale should treat the ISO 30112 POSIX space characters, which includes U+2002, as whitespace.
anii.kmn and sil_kmhmu.kmn both have mismatching case in filename references for icons. For now, we will disable tests for these two keyboards, so that tests pass on Linux (which has case-sensitive filesystem). Note: the filename case was already addressed in the keyboards repo, so when we realign to a more recent commit for the test fixtures, we should be able to include these tests again. Relates-to: #12623
…mcets, fv_nuucaanul
|
Follow-up disabled tests in 19.0 in #12634. |
The
--full-testparameter in kmcmplib build.sh has not been working. This PR reconnects the parameter and also enables it by default for CI test builds (not release builds).Fixes: #12623
@keymanapp-test-bot skip