chore: update minimum versions #12632
Open
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested review from
jahorton,
darcywong00 and
sgschantz
as code owners
github-actions
bot
added
android/
developer/
common/
common/resources/
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Nov 6, 2024
| @@ -50,10 +50,14 @@ https://help.keyman.com/developer/engine/android/latest-version/ | |||
| |-----------------------------------|--------------| | |||
| | KEYMAN_DEFAULT_VERSION_UBUNTU_CONTAINER | noble | | |||
| | KEYMAN_MIN_TARGET_VERSION_ANDROID | 5 | | |||
There was a problem hiding this comment.
Suggested change
| | KEYMAN_MIN_TARGET_VERSION_ANDROID | 5 | | |
| | KEYMAN_MIN_TARGET_VERSION_ANDROID | 5.0 | |
I should have made this clearer so not to confuse 5.1 (SDK 22)
There was a problem hiding this comment.
can you apply to l.13 of minimum-versions.inc.sh?
There was a problem hiding this comment.
minimum versions are correct for mac and ios but I expect them to change before we release 18 as we make the move to Xcode 16
darcywong00
reviewed
Nov 6, 2024
| @@ -15,7 +15,14 @@ KEYMAN_MIN_TARGET_VERSION_IOS=12.2 # iOS 12.2 | |||
| KEYMAN_MIN_TARGET_VERSION_WINDOWS=10 # Windows 10 | |||
| KEYMAN_MIN_TARGET_VERSION_MAC=10.13 # MacOS 10.13 (High Sierra) | |||
| KEYMAN_MIN_TARGET_VERSION_UBUNTU=20.04 # Ubuntu 20.04 Focal | |||
| KEYMAN_MIN_TARGET_VERSION_CHROME=95.0 # Final version that runs on Android 5.0 | |||
| KEYMAN_MIN_TARGET_VERSION_ANDROID_CHROME=53.0 # min vesrion of Chrome for Keyman for Android | |||
There was a problem hiding this comment.
Suggested change
| KEYMAN_MIN_TARGET_VERSION_ANDROID_CHROME=53.0 # min vesrion of Chrome for Keyman for Android | |
| KEYMAN_MIN_TARGET_VERSION_ANDROID_CHROME=53.0 # min version of Chrome for Keyman for Android |
sgschantz
approved these changes
Nov 6, 2024
darcywong00
approved these changes
Nov 6, 2024
ermshiperete
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip