Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): prototype of ldml visual editor 🗼 #12790

Draft
wants to merge 10 commits into
base: chore/merge-master-into-epic-ldml-editor
Choose a base branch
from
Draft

feat(developer): prototype of ldml visual editor 🗼 #12790

wants to merge 10 commits into from
+3,998 −58

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Dec 5, 2024 •
edited
Loading

  • minor cleanup to re-add the custom view
  • some comments

Fixes: #12789

@keymanapp-test-bot skip

@srl295 srl295 self-assigned this Dec 5, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Dec 5, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 5, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Dec 5, 2024
@srl295 srl295 changed the title feat(developer): seed ldml visual editor 🗼 feat(developer): prototype of ldml visual editor 🗼 Dec 5, 2024
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Dec 5, 2024
This was referenced Dec 6, 2024
Open
Merged
@srl295 srl295 force-pushed the feat/developer/12756-vscode-build branch 2 times, most recently from cb65131 to f890a57 Compare December 6, 2024 16:02
@srl295 srl295 force-pushed the feat/developer/12789-visual-prototype-epic-ldml-editor branch from e6979b0 to ccd2d54 Compare December 6, 2024 16:13
@srl295 srl295 changed the base branch from feat/developer/12756-vscode-build to feat/developer/12798-vscode-ext-scaffolding-epic-ldml-editor December 6, 2024 16:13
@srl295 srl295 force-pushed the feat/developer/12789-visual-prototype-epic-ldml-editor branch from ccd2d54 to a3dcba3 Compare December 6, 2024 16:34
@darcywong00 darcywong00 modified the milestones: A18S16, A18S17 Dec 7, 2024
@srl295 srl295 force-pushed the feat/developer/12789-visual-prototype-epic-ldml-editor branch from a3dcba3 to ac57afe Compare December 10, 2024 17:20
Base automatically changed from feat/developer/12798-vscode-ext-scaffolding-epic-ldml-editor to epic/ldml-editor December 10, 2024 17:45
@srl295
feat(developer): seed ldml visual editor 🗼
cea397e 
- minor cleanup to re-add the custom view
- some comments

Fixes: #12789
@srl295
chore(developer): add react/parcel 🗼
15c0441 
- add React 19
- parcel builds into build/ which is picked up by the app

Fixes: #12789
@srl295 srl295 force-pushed the feat/developer/12789-visual-prototype-epic-ldml-editor branch from ac57afe to 15c0441 Compare December 16, 2024 14:36
@srl295
chore(developer): update README and package.json 🗼
3ec6f85 
- build fix

Fixes: #12789
@srl295
chore(developer): ldml-editor: unbreak: add version number 🗼
d758a3b 
- without this, the extension inexplicably stops working
- This probably got dropped in the merge
- Was noted in #12835 but wasn't clear this blocked extension operation

Fixes: #12789
@srl295
chore(developer): add an LDMLCompilerManager
e79e92c 
- use an abstraction because of ESModule vs commonjs
@srl295 srl295 force-pushed the feat/developer/12789-visual-prototype-epic-ldml-editor branch from 1bb3011 to e79e92c Compare December 20, 2024 22:58
@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
@srl295
chore(developer): ldml-editor: use NodeCompilerCallbacks 🗼
079270f 
- add an extension point to NodeCompilerCallbacks to support changing message target
- add an LDMLCompilerManager to simplify the CommonJS/ESM boundary

Fixes: #12789
@srl295 srl295 force-pushed the feat/developer/12789-visual-prototype-epic-ldml-editor branch from e9cba89 to 079270f Compare December 24, 2024 13:38
@srl295
Merge branch 'chore/merge-master-into-epic-ldml-editor' into feat/dev…
d77c19f 
…eloper/12789-visual-prototype-epic-ldml-editor
@srl295 srl295 changed the base branch from epic/ldml-editor to chore/merge-master-into-epic-ldml-editor December 24, 2024 13:46
@srl295
chore(developer): update for update from master
b2167fe 
- use correct imports paths
- user gets a fatal error if the keyboard file doesn't compile. But at least it compiles!

Fixes: #12789
@srl295
feat(developer): update React side to show if the keyboard loaded or not
ed94bba 
Fixes: #12789
@srl295
feat(developer): use index.html from parcel
a8fd0dc 
- fixup index.html from parcel and use it. this avoids hard coded hex ids
- also, fix vscode-test.mjs to support correct .tests. name

Fixes: #12789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin will be requested when the pull request is marked ready for review mcdurdin is a code owner

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 will be requested when the pull request is marked ready for review darcywong00 is a code owner

@SabineSIL SabineSIL Awaiting requested review from SabineSIL SabineSIL will be requested when the pull request is marked ready for review SabineSIL is a code owner

@markcsinclair markcsinclair Awaiting requested review from markcsinclair markcsinclair will be requested when the pull request is marked ready for review markcsinclair is a code owner

Assignees

@srl295 srl295

Labels
developer/compilers/ developer/ epic-ldml-editor feat
Projects
Keyman
Status: In Progress
Milestone
A18S18
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @darcywong00