fix(android/app): Temporarily disable Keyman browser

[darcywong00]

Intermediary step towards #2159

This PR temporarily disable access to the in-app browser (Keeps the Keyman app account agonistic)

User Testing

Setup
Install the PR build of Keyman for Android

• TEST_BROWSER_DISABLED - Verifies Keyman browser can't be accessed

1. Launch Keyman for Android in portrait orientation
2. Observe the menu icons and verify the browser icon is not visible
   
3. Rotate the device to landscape orientation
4. Observe the menu icons and verify the browser icon is not visible

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_BROWSER_DISABLED (PASSED): Tested with the attached PR build (Keyman 16.0.139-test-8428) in Android 12 / API 31 emulator and here is my observation: 1. Verified that the browser icon is not visible on the menu icons in both (Potrait and Landscape) orientations. Seems to be working fine. (notes)

[mcdurdin]

LGTM I guess?

[mcdurdin]

Here's how I setup Keyman for Android to allow for a custom CA for use with the Fiddler proxy:

diff --git a/android/KMAPro/kMAPro/src/main/AndroidManifest.xml b/android/KMAPro/kMAPro/src/main/AndroidManifest.xml
index 6acb4d9da..e5e1393ed 100644
--- a/android/KMAPro/kMAPro/src/main/AndroidManifest.xml
+++ b/android/KMAPro/kMAPro/src/main/AndroidManifest.xml
@@ -19,6 +19,7 @@
     android:icon="@mipmap/ic_launcher"
     android:label="@string/app_name"
     android:usesCleartextTraffic="true"
+    android:networkSecurityConfig="@xml/network_security_config"
     android:theme="@style/AppTheme"
     android:supportsRtl="true">
     <receiver android:name=".NetworkStateReceiver"
diff --git a/android/KMAPro/kMAPro/src/main/res/xml/network_security_config.xml b/android/KMAPro/kMAPro/src/main/res/xml/network_security_config.xml
new file mode 100644
index 000000000..ad83b21d7
--- /dev/null
+++ b/android/KMAPro/kMAPro/src/main/res/xml/network_security_config.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+  <base-config>
+    <trust-anchors>
+      <!-- Trust preinstalled CAs -->
+      <certificates src="system" />
+      <!-- HERE: Additionaly trus user added CAs -->
+      <certificates src="user"/>
+    </trust-anchors>
+  </base-config>
+</network-security-config>
\ No newline at end of file

[darcywong00]

Will redo towards 17.0 alpha

[bharanidharanj]

Test Results

• TEST_BROWSER_DISABLED (PASSED): Tested with the attached PR build (Keyman 16.0.139-test-8428) in Android 12 / API 31 emulator and here is my observation: 1. Verified that the browser icon is not visible on the menu icons in both (Potrait and Landscape) orientations. Seems to be working fine.

..in Portrait view

..in Landscape view

[jahorton]

An idea toward replacing / reworking the functionality, longterm: #2159 (comment)

[darcywong00]

From A17S20 planning meeting, we'll go ahead and close this.
Can re-implement if Google Play Store flags a future build.

[darcywong00]

and also replace with https://github.com/keymanapp/keyman-browser

[darcywong00]

We may need to re-implement this as Play Store has been blocking stable builds since
Jan 2023 (last version 16.0.138)