feat(linux): mcompile query data 🐘 #8840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
mcdurdin
force-pushed
the
feature/linux-mcompile-query-data
branch
from
b532101
to
fedbfbf
Compare
mcdurdin
changed the title
SabineSIL
force-pushed
the
feature/linux-mcompile
branch
from
037e517
to
b3a591c
Compare
ermshiperete
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Note that GdkKeymap is deprecated in GTK 4. Therefore I'd prefer if we wouldn't use it.
One possible solution that would work with X11 as well as Wayland would be something along the lines of the implementation of gdk_wayland_keymap_get_entries_for_keycode.
xkb_keymap_new_from_names returns a struct xkb_keymap pointer. xkb_keymap_key_get_syms_by_level then allows to get the keyvals for a given keycode.
…ignore X_bak_foldercosmetics, comments
…e needed; ; replace some DataTypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step necessary for PR #8839. The task is to query the base keyboard data of keyboards
connected to #8839
@keymanapp-test-bot skip