feat(common): precompile ajv schemas 🎺 #9691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
feat
labels
Fixes #9640. This ended up being somewhat more fragile than originally anticipated. For the `ajv` cli call to get the right versions, we needed to install ajv as a dev dependency in the top-level package.json as well as at the common/web/types level. Ajv does not do all that well with ESM yet, either, so we use esbuild to transform the compiled validators before building in typescript.
mcdurdin
force-pushed
the
feat/common/9640-precompile-schemas
branch
from
b4f0345
to
225877f
Compare
mcdurdin
changed the title
keymanapp-test-bot
bot
removed
the
user-test-missing
jahorton
approved these changes
Oct 6, 2023
mcdurdin
commented
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9640.
This ended up being somewhat more fragile than originally anticipated. For the
ajvcli call to get the right versions, we needed to install ajv as a dev dependency in the top-level package.json as well as at the common/web/types level.Ajv does not do all that well with ESM yet, either, so we use esbuild to transform the compiled validators before building in typescript. References that were useful in getting this right:
--code-esmsupport ajv-validator/ajv-cli#200@keymanapp-test-bot skip