-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge master into linux-mcompile 🐘 #9870
Merged
mcdurdin
merged 172 commits into
epic/linux-mcompile
from
chore/merge-master-into-linux-mcompile
Oct 27, 2023
Merged
chore: merge master into linux-mcompile 🐘 #9870
mcdurdin
merged 172 commits into
epic/linux-mcompile
from
chore/merge-master-into-linux-mcompile
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- syslog() will automatically add newlines (per mac and linux manpages) - there's no reason to add NL *AND* add std::endl - this fix will cause syslog to have no newline going in, and print only one instead of two newlines on other platforms/environments
- colorize ldml test For: #9468
- 0 steps forward, 4294967294 steps back For: #9468
chore(web): web build streamlining
chore(linux): Add code coverage reports for keyman-config and keyman-system-service
- change tests to NFD for now For: #9468
- split out 'process_key_string' For: #9468
auto: increment master version to 17.0.191
- change more tests to NFD for now For: #9468
- more progress in the normalization pipeline. Trying to keep it from leaking. - normalize output to NFC. - normalize json test data to NFC (both context and expected). - we do NOT try to normalize the 'embedded' strings currently. - yet more test data fixes (turns out u+00e0 ≠ u+00e8) For: #9468
- fix windows build For: #9468
- fix unnecessary test churn. For: #9468
keyman-server
requested review from
mcdurdin,
sgschantz,
SabineSIL and
darcywong00
as code owners
October 27, 2023 02:19
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
chore: merge master into linux-mcompile
chore: merge master into linux-mcompile 🐘
Oct 27, 2023
mcdurdin
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip