Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): manage SourcePath in project upgrade 🦕 #9986

Merged

Conversation

mcdurdin
Copy link
Member

Relates to #9948.

When upgrading a project to v2.0, it is important that all source files are in the same folder. This change makes the upgrade process verify that this is the case and blocks the upgrade if there are source files in multiple folders.

Source files are .kmn, .xml (ldml keyboard), .kps, and .model.ts.

Note: cleanups in other units are removing unused code.

@keymanapp-test-bot skip

Relates to #9948.

When upgrading a project to v2.0, it is important that all source files
are in the same folder. This change makes the upgrade process verify
that this is the case and blocks the upgrade if there are source files
in multiple folders.

Source files are .kmn, .xml (ldml keyboard), .kps, and .model.ts.
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 13, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S26 milestone Nov 13, 2023
@mcdurdin mcdurdin changed the title chore(developer): manage SourcePath in project upgrade chore(developer): manage SourcePath in project upgrade 🦕 Nov 13, 2023
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from chore/developer/9948-only-build-source-files to master November 15, 2023 02:48
@mcdurdin mcdurdin merged commit 4ac71cc into master Nov 15, 2023
5 checks passed
@mcdurdin mcdurdin deleted the chore/developer/9948-manage-sourcepath-in-upgrade-project branch November 15, 2023 02:48
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.211-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants