chore(developer): handle project version checks cleanly in kmc 🦕 #9996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #9948. While the schema validation does check the version already, it gives a fairly obtuse message, and we can do better. Found a secondary issue with a iterator type guard needed in kpj-file-reader when preparing unit test, which was probably masked in other tests by not verifying all messages generated, so updated all infrastructure message tests to verify the full set of messages generated.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
chore
labels
69 tasks
mcdurdin
changed the title
Base automatically changed from
chore/developer/9948-only-source-path-files-in-project-views
to
master
November 15, 2023 02:48
mcdurdin
deleted the
chore/developer/9948-handle-project-version-cleanly-in-kmc
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9948.
While the schema validation does check the version already, it gives a fairly obtuse message, and we can do better.
Found a secondary issue with a iterator type guard needed in kpj-file-reader when preparing unit test, which was probably masked in other tests by not verifying all messages generated, so updated all infrastructure message tests to verify the full set of messages generated.
@keymanapp-test-bot skip