added order param and removed sort param

keyshade-xyz · Jul 27, 2024 · f054806 · f054806
1 parent b906512
commit f054806
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/apps/api/src/secret/controller/secret.controller.ts b/apps/api/src/secret/controller/secret.controller.ts
@@ -110,15 +110,15 @@ export class SecretController {
  @Param('environmentId') environmentId: string,
  @Query('page') page: number = 0,
  @Query('limit') limit: number = 10,
- @Query('sort') sort: string = 'version'
+ @Query('order') order: string = 'desc'
  ) {
  return await this.secretService.getRevisionsOfSecret(
  user,
  secretId,
  environmentId,
  page,
  limit,
- sort
+ order
  )
  }
 }
diff --git a/apps/api/src/secret/service/secret.service.ts b/apps/api/src/secret/service/secret.service.ts
@@ -497,8 +497,10 @@ export class SecretService {
  environmentId: Environment['id'],
  page: number,
  limit: number,
- sort: string
+ order: string
  ) {
+ // assign order to variable dynamically
+ const sortOrder = order === 'asc' ? 'asc' : 'desc'
  //check access to secret
  await this.authorityCheckerService.checkAuthorityOverSecret({
  userId: user.id,
@@ -523,7 +525,7 @@ export class SecretService {
  skip: page * limit,
  take: limit,
  orderBy: {
- [sort]: sort
+ version: sortOrder
  }
  })
  return revisions