Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): Migrated to cookie based authentication #206

Merged
merged 1 commit into from
May 11, 2024

Conversation

rajdip-b
Copy link
Member

Description

Give a summary of the change that you have made

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

Copy link
Contributor

Failed to generate code suggestions for PR

Copy link

sonarcloud bot commented May 11, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.38%. Comparing base (7bb3d21) to head (13c9141).
Report is 56 commits behind head on develop.

Files Patch % Lines
apps/api/src/auth/guard/auth/auth.guard.ts 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #206       +/-   ##
============================================
+ Coverage    62.20%   91.38%   +29.17%     
============================================
  Files           76      104       +28     
  Lines         1503     2414      +911     
  Branches       260      454      +194     
============================================
+ Hits           935     2206     +1271     
+ Misses         568      208      -360     
Flag Coverage Δ
api-e2e-tests 91.38% <57.14%> (+29.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajdip-b rajdip-b merged commit ad6911f into develop May 11, 2024
6 of 7 checks passed
rajdip-b pushed a commit that referenced this pull request May 12, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-05-12)

### 🚀 Features

* Add approval support ([#158](#158)) ([e09ae60](e09ae60))
* **api:** Add configuration live update support ([#181](#181)) ([f7d6684](f7d6684))
* **api:** Add feature to export data of a workspace ([#152](#152)) ([46833aa](46833aa))
* **api:** Add Integration support ([#203](#203)) ([f1ae87e](f1ae87e))
* **api:** Add note to [secure] and variable ([#151](#151)) ([2e62351](2e62351))
* **api:** Add OAuth redirection and polished authentication ([#212](#212)) ([d2968bc](d2968bc))
* **api:** Add support for storing and managing variables ([#149](#149)) ([963a8ae](963a8ae))
* **api:** Added GitLab OAuth ([#188](#188)) ([4d3bbe4](4d3bbe4))
* **api:** Added validation for reason field ([#190](#190)) ([90b8ff2](90b8ff2))
* **api:** Create default workspace on user's creation ([#182](#182)) ([3dc0c4c](3dc0c4c))
* **api:** Reading `port` Dynamically ([#170](#170)) ([fd46e3e](fd46e3e))
* **auth:** Add Google OAuth ([#156](#156)) ([cf387ea](cf387ea))
* **web:** Added waitlist ([#168](#168)) ([1084c77](1084c77))
* **web:** Landing revamp ([#165](#165)) ([0bc723b](0bc723b))

### 🐛 Bug Fixes

* **web:** alignment issue in “Collaboration made easy” section ([#178](#178)) ([df5ca75](df5ca75))
* **workspace:** delete duplicate tailwind config ([99d922a](99d922a))

### 📚 Documentation

* add contributor list ([f37569a](f37569a))
* Add integration docs ([#204](#204)) ([406ddb7](406ddb7))
* Added integration docs to gitbook summary ([ab37530](ab37530))
* **api:** Add swagger docs of API key controller ([#167](#167)) ([2910476](2910476))
* **api:** Add swagger docs of User Controller ([#166](#166)) ([fd59522](fd59522))
* fix typo in environment-variables.md ([#163](#163)) ([48294c9](48294c9))
* Remove supabase from docs ([#169](#169)) ([eddbce8](eddbce8))
* **setup:** replace NX with Turbo in setup instructions ([#175](#175)) ([af8a460](af8a460))
* Update README.md ([b59f16b](b59f16b))
* Update running-the-api.md ([177dbbf](177dbbf))
* Update running-the-api.md ([#193](#193)) ([3d5bcac](3d5bcac))

### 🔧 Miscellaneous Chores

* Added lockfile ([60a3b9b](60a3b9b))
* Added lockfile ([6bb512c](6bb512c))
* **api:** Added type inference and runtime validation to `process.env` ([#200](#200)) ([249e07d](249e07d))
* **api:** Fixed prisma script env errors ([#209](#209)) ([8762354](8762354))
* **API:** Refactor authority check functions in API ([#189](#189)) ([e9d710d](e9d710d))
* **api:** Refactor user e2e tests ([b38d45a](b38d45a))
* **ci:** Disabled api stage release ([97877c4](97877c4))
* **ci:** Update stage deployment config ([868a6a1](868a6a1))
* **codecov:** update api-e2e project coverage ([1e90d7e](1e90d7e))
* **dockerfile:** Fixed web dockerfile ([6134bb2](6134bb2))
* **docker:** Optimized web Dockerfile to reduct image size ([#173](#173)) ([444286a](444286a))
* **release:** Downgraded package version ([c173fee](c173fee))
* **release:** Fix failing release ([#213](#213)) ([40f64f3](40f64f3))
* **release:** Install pnpm ([1081bea](1081bea))
* **release:** Updated release commit ([b8958e7](b8958e7))
* **release:** Updated release commit ([e270eb8](e270eb8))
* Update deprecated husky Install command ([#202](#202)) ([e61102c](e61102c))
* Upgrade @million/lint from 0.0.66 to 0.0.73 ([#172](#172)) ([dd43ed9](dd43ed9))
* **web:** Updated fly memory config ([4debc66](4debc66))

### 🔨 Code Refactoring

* **api:** Made events central to workspace ([#159](#159)) ([9bc00ae](9bc00ae))
* **api:** Migrated to cookie based authentication ([#206](#206)) ([ad6911f](ad6911f))
* **monorepo:** Migrate from nx to turbo ([#153](#153)) ([88b4b00](88b4b00))
@rajdip-b
Copy link
Member Author

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rajdip-b rajdip-b deleted the refactor/cookie-based-authentication branch May 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant