Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(setup): replace NX with Turbo in setup instructions #175

Merged

Conversation

voi-jankowski
Copy link
Contributor

@voi-jankowski voi-jankowski commented Apr 6, 2024

User description

Description

This update modifies the project's setup documentation to replace the outdated NX setup instructions with the new Turbo setup instructions. This change reflects our shift to using Turbo for monorepo management, aligning the documentation with our current development practices.

Fixes #174

Dependencies

  • No new dependencies introduced. The change is in documentation only.

Mentions

@rajdip-b

Changes Walkthrough

Relevant Files:

Relevant Files
Documentation
##setting-things-up.md
replace NX with Turbo in setup instructions

docs/contributing-to-keyshade/setting-things-up.md

  • Removed references to installing NX as the monorepo management tool.
  • Added new section detailing the installation process for Turbo, including global installation via npm.
+1/-1

Developer's checklist

  • [✅] My PR follows the style guidelines of this project
  • [✅] I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • [✅] This PR requires an update to the documentation at docs.keyshade.xyz
  • [✅] I have made the necessary updates to the documentation, or no documentation changes are required.

Type

Documentation


Description

  • Updated the setup documentation to replace NX with Turbo as the monorepo management tool.
  • Provided the command for global installation of Turbo.
  • Added a link to the official Turbo documentation for further reading.

Changes walkthrough

Relevant files
Documentation
setting-things-up.md
Update Setup Instructions to Use Turbo                                     

docs/contributing-to-keyshade/setting-things-up.md

  • Replaced NX installation instructions with Turbo.
  • Added a command for installing Turbo globally.
  • Included a reference to the official Turbo documentation.
  • +5/-3     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @codiumai-pr-agent-free codiumai-pr-agent-free bot added the type: documentation Improvements or additions to documentation label Apr 6, 2024
    Copy link
    Contributor

    PR Description updated to latest commit (bb751dd)

    Copy link

    sonarcloud bot commented Apr 6, 2024

    Quality Gate Passed Quality Gate passed

    Issues
    0 New issues
    0 Accepted issues

    Measures
    0 Security Hotspots
    No data about Coverage
    No data about Duplication

    See analysis details on SonarCloud

    Copy link
    Contributor

    PR Review

    ⏱️ Estimated effort to review [1-5]

    1, because the PR involves straightforward documentation updates with clear instructions on replacing NX with Turbo for monorepo management. The changes are concise and focused solely on the setup instructions, making it easy to review.

    🧪 Relevant tests

    No

    🔍 Possible issues

    No

    🔒 Security concerns

    No


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

    The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

    • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    
    [pr_reviewer]
    some_config1=...
    some_config2=...
    

    See the review usage page for a comprehensive guide on using this tool.

    Copy link
    Contributor

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Enhancement
    Add rationale for transitioning from NX to Turbo.

    Consider adding a brief explanation or rationale for the transition from NX to Turbo. This
    can help contributors understand the decision-making process and the benefits of using
    Turbo over NX.

    docs/contributing-to-keyshade/setting-things-up.md [45-47]

     ## Installing Turbo
     
    -The final step involves installing our monorepo management tool. We have transitioned to using Turbo to streamline our development process. To install Turbo, run the following command:
    +The final step involves installing our monorepo management tool. We have transitioned to using Turbo from NX to streamline our development process, due to its faster build times and more efficient handling of monorepo dependencies. To install Turbo, run the following command:
     
    Specify the environment for running commands.

    To ensure clarity and consistency, consider specifying the command line interface (CLI) or
    terminal as the environment for running the provided commands, especially for contributors
    who might be less familiar with development environments.

    docs/contributing-to-keyshade/setting-things-up.md [42]

    -To install the dependencies, run the following command:
    +To install the dependencies, open your command line interface (CLI) or terminal and run the following command:
     
    Add a description for the external Turbo documentation link.

    For better accessibility and to assist users who might face issues while navigating
    external links, consider adding a brief description of what users can expect to find in
    the Turbo documentation link provided.

    docs/contributing-to-keyshade/setting-things-up.md [53]

    -For more information on how to get started with Turbo, refer to the [official Turbo documentation](https://turbo.build/repo/docs).
    +For more information on how to get started with Turbo, including setup guides, best practices, and troubleshooting, refer to the [official Turbo documentation](https://turbo.build/repo/docs).
     
    Best practice
    Use consistent package manager for global installations.

    It's recommended to use the same package manager consistently across the project
    documentation. Since pnpm is used for installing dependencies initially, consider using
    pnpm for installing Turbo globally as well, if supported.

    docs/contributing-to-keyshade/setting-things-up.md [50]

     ```bash
    -npm install turbo --global
    +pnpm add --global turbo
                       
    </details></td></tr><tr><td rowspan=1><strong>Maintainability</strong></td>
    <td>
    
    
    
    <details><summary>Use a more formal tone in the instructions.</summary>
    
    ___
    
    
    **To maintain a consistent and professional tone throughout the document, consider using a <br>more formal tone in the instructions. For example, instead of "you would need," use "you <br>will need."**
        
    [docs/contributing-to-keyshade/setting-things-up.md [57]](https://github.com/keyshade-xyz/keyshade/pull/175/files#diff-cef348a8823f15a58b87562625cba74999f427c52980164863ee234f45897d44R57-R57)
    
    ```diff
    -If you plan to work on the API, you would need the **NestJS CLI.** To do this, simply run:
    +If you plan to work on the API, you will need the **NestJS CLI.** To install it, run the following command:
     
    

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

    • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    
    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    

    See the improve usage page for a comprehensive guide on using this tool.

    Copy link
    Member

    @rajdip-b rajdip-b left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks perfect! Thanks @voi-jankowski <3

    @rajdip-b rajdip-b merged commit af8a460 into keyshade-xyz:develop Apr 6, 2024
    8 checks passed
    rajdip-b pushed a commit that referenced this pull request May 12, 2024
    ## [1.3.0](v1.2.0...v1.3.0) (2024-05-12)
    
    ### 🚀 Features
    
    * Add approval support ([#158](#158)) ([e09ae60](e09ae60))
    * **api:** Add configuration live update support ([#181](#181)) ([f7d6684](f7d6684))
    * **api:** Add feature to export data of a workspace ([#152](#152)) ([46833aa](46833aa))
    * **api:** Add Integration support ([#203](#203)) ([f1ae87e](f1ae87e))
    * **api:** Add note to [secure] and variable ([#151](#151)) ([2e62351](2e62351))
    * **api:** Add OAuth redirection and polished authentication ([#212](#212)) ([d2968bc](d2968bc))
    * **api:** Add support for storing and managing variables ([#149](#149)) ([963a8ae](963a8ae))
    * **api:** Added GitLab OAuth ([#188](#188)) ([4d3bbe4](4d3bbe4))
    * **api:** Added validation for reason field ([#190](#190)) ([90b8ff2](90b8ff2))
    * **api:** Create default workspace on user's creation ([#182](#182)) ([3dc0c4c](3dc0c4c))
    * **api:** Reading `port` Dynamically ([#170](#170)) ([fd46e3e](fd46e3e))
    * **auth:** Add Google OAuth ([#156](#156)) ([cf387ea](cf387ea))
    * **web:** Added waitlist ([#168](#168)) ([1084c77](1084c77))
    * **web:** Landing revamp ([#165](#165)) ([0bc723b](0bc723b))
    
    ### 🐛 Bug Fixes
    
    * **web:** alignment issue in “Collaboration made easy” section ([#178](#178)) ([df5ca75](df5ca75))
    * **workspace:** delete duplicate tailwind config ([99d922a](99d922a))
    
    ### 📚 Documentation
    
    * add contributor list ([f37569a](f37569a))
    * Add integration docs ([#204](#204)) ([406ddb7](406ddb7))
    * Added integration docs to gitbook summary ([ab37530](ab37530))
    * **api:** Add swagger docs of API key controller ([#167](#167)) ([2910476](2910476))
    * **api:** Add swagger docs of User Controller ([#166](#166)) ([fd59522](fd59522))
    * fix typo in environment-variables.md ([#163](#163)) ([48294c9](48294c9))
    * Remove supabase from docs ([#169](#169)) ([eddbce8](eddbce8))
    * **setup:** replace NX with Turbo in setup instructions ([#175](#175)) ([af8a460](af8a460))
    * Update README.md ([b59f16b](b59f16b))
    * Update running-the-api.md ([177dbbf](177dbbf))
    * Update running-the-api.md ([#193](#193)) ([3d5bcac](3d5bcac))
    
    ### 🔧 Miscellaneous Chores
    
    * Added lockfile ([60a3b9b](60a3b9b))
    * Added lockfile ([6bb512c](6bb512c))
    * **api:** Added type inference and runtime validation to `process.env` ([#200](#200)) ([249e07d](249e07d))
    * **api:** Fixed prisma script env errors ([#209](#209)) ([8762354](8762354))
    * **API:** Refactor authority check functions in API ([#189](#189)) ([e9d710d](e9d710d))
    * **api:** Refactor user e2e tests ([b38d45a](b38d45a))
    * **ci:** Disabled api stage release ([97877c4](97877c4))
    * **ci:** Update stage deployment config ([868a6a1](868a6a1))
    * **codecov:** update api-e2e project coverage ([1e90d7e](1e90d7e))
    * **dockerfile:** Fixed web dockerfile ([6134bb2](6134bb2))
    * **docker:** Optimized web Dockerfile to reduct image size ([#173](#173)) ([444286a](444286a))
    * **release:** Downgraded package version ([c173fee](c173fee))
    * **release:** Fix failing release ([#213](#213)) ([40f64f3](40f64f3))
    * **release:** Install pnpm ([1081bea](1081bea))
    * **release:** Updated release commit ([b8958e7](b8958e7))
    * **release:** Updated release commit ([e270eb8](e270eb8))
    * Update deprecated husky Install command ([#202](#202)) ([e61102c](e61102c))
    * Upgrade @million/lint from 0.0.66 to 0.0.73 ([#172](#172)) ([dd43ed9](dd43ed9))
    * **web:** Updated fly memory config ([4debc66](4debc66))
    
    ### 🔨 Code Refactoring
    
    * **api:** Made events central to workspace ([#159](#159)) ([9bc00ae](9bc00ae))
    * **api:** Migrated to cookie based authentication ([#206](#206)) ([ad6911f](ad6911f))
    * **monorepo:** Migrate from nx to turbo ([#153](#153)) ([88b4b00](88b4b00))
    @rajdip-b
    Copy link
    Member

    🎉 This PR is included in version 1.3.0 🎉

    The release is available on GitHub release

    Your semantic-release bot 📦🚀

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    type: documentation Improvements or additions to documentation
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Replace nx in docs with turbo
    2 participants