Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added docker build and run commands to package.json #258

Merged
merged 4 commits into from
Jun 7, 2024
Merged

chore: Added docker build and run commands to package.json #258

merged 4 commits into from
Jun 7, 2024

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Jun 6, 2024

Description

Added docker build and run commands._

Fixes #257

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

@vr-varad vr-varad changed the title Added docker build and run commands to package.json fix: Added docker build and run commands to package.json Jun 6, 2024
@vr-varad
Copy link
Contributor Author

vr-varad commented Jun 6, 2024

@rajdip-b done.

Copy link
Member

@rajdip-b rajdip-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands look good. Can you additionally add --env-file .env to the run commands?

@rajdip-b rajdip-b changed the title fix: Added docker build and run commands to package.json chore: Added docker build and run commands to package.json Jun 6, 2024
Copy link
Contributor

Failed to generate code suggestions for PR

@vr-varad
Copy link
Contributor Author

vr-varad commented Jun 6, 2024

@rajdip-b made the suggested changes

@rajdip-b
Copy link
Member

rajdip-b commented Jun 6, 2024

Cool! I'll test them out.

Copy link
Member

@rajdip-b rajdip-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey man, the PR looks good and works fine. I just forgot to mention two other flags:

  • --name <container name>
  • --rm

Once you have added these, we are good to merge!

@vr-varad
Copy link
Contributor Author

vr-varad commented Jun 7, 2024

@rajdip-b done

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rajdip-b rajdip-b merged commit af61791 into keyshade-xyz:develop Jun 7, 2024
4 checks passed
rajdip-b pushed a commit that referenced this pull request Jun 12, 2024
## [2.0.0](v1.4.0...v2.0.0) (2024-06-12)

### ⚠ BREAKING CHANGES

* **api:** Refactor environment, [secure] and variable functionality

### 🚀 Features

* **platform:** Workspace integrate ([#241](#241)) ([6107e7d](6107e7d))

### 📚 Documentation

* Fix broken links in README.md ([9266788](9266788))
* Modified environment-variable.md ([#256](#256)) ([4974756](4974756))

### 🔧 Miscellaneous Chores

* Added docker build and run commands to` package.json` ([#258](#258)) ([af61791](af61791))
* **api:** Fix inconsistencies in zod schema ([#240](#240)) ([f3a3632](f3a3632))
* **ci:** Update deploy web ([e80d47d](e80d47d))
* **docker:** Grant correct permissions to docker image ([#251](#251)) ([49546aa](49546aa))
* Update GitHub Action plugin versions  ([#263](#263)) ([020bbf6](020bbf6))
* Update package versions for release ([93785be](93785be))

### 🔨 Code Refactoring

* **api:** Refactor environment, [secure] and variable functionality ([#270](#270)) ([55a6d37](55a6d37))
* **api:** Replace for loop with array indexing while decrypting [secure]s during bulk fetch [#265](#265) ([#266](#266)) ([62a1731](62a1731))
* **api:** Update return type while fetching [secure]s and variables ([#264](#264)) ([fd36abd](fd36abd))
@rajdip-b
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rajdip-b pushed a commit that referenced this pull request Jun 27, 2024
## [2.0.0](v1.4.0...v2.0.0) (2024-06-12)

### ⚠ BREAKING CHANGES

* **api:** Refactor environment, [secure] and variable functionality

### 🚀 Features

* **platform:** Workspace integrate ([#241](#241)) ([6107e7d](6107e7d))

### 📚 Documentation

* Fix broken links in README.md ([9266788](9266788))
* Modified environment-variable.md ([#256](#256)) ([4974756](4974756))

### 🔧 Miscellaneous Chores

* Added docker build and run commands to` package.json` ([#258](#258)) ([af61791](af61791))
* **api:** Fix inconsistencies in zod schema ([#240](#240)) ([f3a3632](f3a3632))
* **ci:** Update deploy web ([e80d47d](e80d47d))
* **docker:** Grant correct permissions to docker image ([#251](#251)) ([49546aa](49546aa))
* Update GitHub Action plugin versions  ([#263](#263)) ([020bbf6](020bbf6))
* Update package versions for release ([93785be](93785be))

### 🔨 Code Refactoring

* **api:** Refactor environment, [secure] and variable functionality ([#270](#270)) ([55a6d37](55a6d37))
* **api:** Replace for loop with array indexing while decrypting [secure]s during bulk fetch [#265](#265) ([#266](#266)) ([62a1731](62a1731))
* **api:** Update return type while fetching [secure]s and variables ([#264](#264)) ([fd36abd](fd36abd))
yogesh1801 pushed a commit to yogesh1801/keyshade that referenced this pull request Jun 29, 2024
## [2.0.0](keyshade-xyz/keyshade@v1.4.0...v2.0.0) (2024-06-12)

### ⚠ BREAKING CHANGES

* **api:** Refactor environment, [secure] and variable functionality

### 🚀 Features

* **platform:** Workspace integrate ([keyshade-xyz#241](keyshade-xyz#241)) ([6107e7d](keyshade-xyz@6107e7d))

### 📚 Documentation

* Fix broken links in README.md ([9266788](keyshade-xyz@9266788))
* Modified environment-variable.md ([keyshade-xyz#256](keyshade-xyz#256)) ([4974756](keyshade-xyz@4974756))

### 🔧 Miscellaneous Chores

* Added docker build and run commands to` package.json` ([keyshade-xyz#258](keyshade-xyz#258)) ([af61791](keyshade-xyz@af61791))
* **api:** Fix inconsistencies in zod schema ([keyshade-xyz#240](keyshade-xyz#240)) ([f3a3632](keyshade-xyz@f3a3632))
* **ci:** Update deploy web ([e80d47d](keyshade-xyz@e80d47d))
* **docker:** Grant correct permissions to docker image ([keyshade-xyz#251](keyshade-xyz#251)) ([49546aa](keyshade-xyz@49546aa))
* Update GitHub Action plugin versions  ([keyshade-xyz#263](keyshade-xyz#263)) ([020bbf6](keyshade-xyz@020bbf6))
* Update package versions for release ([93785be](keyshade-xyz@93785be))

### 🔨 Code Refactoring

* **api:** Refactor environment, [secure] and variable functionality ([keyshade-xyz#270](keyshade-xyz#270)) ([55a6d37](keyshade-xyz@55a6d37))
* **api:** Replace for loop with array indexing while decrypting [secure]s during bulk fetch [keyshade-xyz#265](keyshade-xyz#265) ([keyshade-xyz#266](keyshade-xyz#266)) ([62a1731](keyshade-xyz@62a1731))
* **api:** Update return type while fetching [secure]s and variables ([keyshade-xyz#264](keyshade-xyz#264)) ([fd36abd](keyshade-xyz@fd36abd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker build and run commands to package.json
2 participants