Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(web): Add documentation about our web package #268

Merged
merged 6 commits into from
Jun 28, 2024
Merged

docs(web): Add documentation about our web package #268

merged 6 commits into from
Jun 28, 2024

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Jun 11, 2024

User description

Description

Give a summary of the change that you have made

Fixes #219

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

Documentation


Description

  • Added new documentation for the web application.
  • Detailed the tech stack including Next.js, React, MDX, Tailwind CSS, Framer Motion, Geist, @tsparticles, Sonner, and TypeScript.
  • Explained the directory structure, including app, components, and utils directories.

Changes walkthrough 📝

Relevant files
Documentation
web.md
Add documentation for web application structure and stack

docs/contributing-to-keyshade/design-of-our-code/web.md

  • Added documentation for the web application.
  • Described the tech stack used in the web application.
  • Provided a detailed directory structure explanation.
  • +56/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    codiumai-pr-agent-free bot commented Jun 11, 2024

    PR Reviewer Guide 🔍

    (Review updated until commit ffbd107)

    ⏱️ Estimated effort to review [1-5]

    1

    🧪 Relevant tests

    No

    🔒 Security concerns

    No

    ⚡ Key issues to review

    None

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for PR.

    @vr-varad
    Copy link
    Contributor Author

    Would be adding to this pr as I find add more about webpage.

    @vr-varad vr-varad changed the title Adding documentation about our web package feat: Adding documentation about our web package Jun 11, 2024
    @rajdip-b rajdip-b changed the title feat: Adding documentation about our web package docs(web): Add documentation about our web package Jun 11, 2024
    @rajdip-b rajdip-b marked this pull request as draft June 11, 2024 09:50
    @rajdip-b
    Copy link
    Member

    Converted it to draft!

    @vr-varad
    Copy link
    Contributor Author

    @rajdip-b I have added stack and structure is there anymore than can be added

    Copy link
    Member

    @rajdip-b rajdip-b left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This looks good to me! @kriptonian1 what do you think?

    @rajdip-b rajdip-b marked this pull request as ready for review June 12, 2024 09:04
    Copy link
    Contributor

    Persistent review updated to latest commit ffbd107

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for PR.

    @kriptonian1
    Copy link
    Contributor

    This looks good to me! @kriptonian1 what do you think?

    let me have a look

    Copy link

    sonarcloud bot commented Jun 12, 2024

    Quality Gate Passed Quality Gate passed

    Issues
    0 New issues
    0 Accepted issues

    Measures
    0 Security Hotspots
    No data about Coverage
    No data about Duplication

    See analysis details on SonarCloud

    @vr-varad
    Copy link
    Contributor Author

    @rajdip-b DId some changes can u have a look whenever you have a chance?

    Comment on lines 30 to 31
    | | ├── privacy
    | | └── terms_and_condition
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Don't show files, just show the folders. As files changes often.

    @kriptonian1
    Copy link
    Contributor

    kriptonian1 commented Jun 12, 2024

    @rajdip-b , do you believe it would be appropriate to mention the Next.js convention files separately, or should we simply provide a link to the Next.js website for contributors to access the file structure?

    @rajdip-b
    Copy link
    Member

    @rajdip-b , do you believe it would be appropriate to mention the Next.js convention files separately, or should we simply provide a link to the Next.js website for contributors to access the file structure?

    Just a link would be sufficient ig

    @kriptonian1 kriptonian1 linked an issue Jun 26, 2024 that may be closed by this pull request
    @vr-varad
    Copy link
    Contributor Author

    @rajdip-b was not well for a week so couldn't work on it. Will be regular from now.
    Are there any more changes required I have removed the files and kept only folders.

    Copy link
    Member

    @rajdip-b rajdip-b left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The content looks good. Just that you forgot to reference this file in the index, so it's not showing up:

    Reference the new file in this and this files.

    image

    @vr-varad
    Copy link
    Contributor Author

    Done @rajdip-b

    Copy link
    Member

    @rajdip-b rajdip-b left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM 🚀

    @rajdip-b rajdip-b merged commit b272df3 into keyshade-xyz:develop Jun 28, 2024
    5 checks passed
    @rajdip-b
    Copy link
    Member

    Thanks for the PR! We would need to add a lot of technical docs, so if you are interested, do ping us on Discord so we can walk you through the requirements :D

    yogesh1801 pushed a commit to yogesh1801/keyshade that referenced this pull request Jun 29, 2024
    rajdip-b pushed a commit that referenced this pull request Jul 11, 2024
    ## [2.2.0](v2.1.0...v2.2.0) (2024-07-11)
    
    ### 🚀 Features
    
    * **api-client:** Added API Client package ([#346](#346)) ([6734e1e](6734e1e))
    * **api:** Updated API key ([fbac312](fbac312))
    * **platform:** View [secure]s ([#313](#313)) ([97c4541](97c4541))
    * **web:** Add Pricing Page ([#243](#243)) ([2c7f1d6](2c7f1d6))
    
    ### 📚 Documentation
    
    * **cli:** Added docs for the CLI package ([#329](#329)) ([edad166](edad166))
    * **cli:** Added usage docs ([#330](#330)) ([b6963d5](b6963d5))
    * Update Discord link ([871b6cd](871b6cd))
    * Update README.md ([e66fcd2](e66fcd2))
    * **web:** Add documentation about our web package ([#268](#268)) ([3d848e7](3d848e7))
    
    ### 🔧 Miscellaneous Chores
    
    * **api:** Updated response types in environment service ([b8a3ddd](b8a3ddd))
    * **ci:** Added release scripts for platform and api ([02dae60](02dae60))
    * **CI:** Updated action plugin versions ([88bb317](88bb317))
    * **CI:** Updated pnpm version in CI file ([2692e88](2692e88))
    * **platform:** Fixed env parsing in platform ([d6ffafa](d6ffafa))
    * **web:** Update Terms and Conditions and Privacy Policy ([#282](#282)) ([d621dcb](d621dcb))
    
    ### 🔨 Code Refactoring
    
    * **api:** Update [secure] and variable fetching endpoints ([7d9acd0](7d9acd0))
    * **cli:** Refactored profile commands into readable blocks ([#331](#331)) ([4a8a089](4a8a089))
    * **cli:** Updated configuration commands and mechanism ([#310](#310)) ([9079b6d](9079b6d))
    rajdip-b pushed a commit that referenced this pull request Jul 11, 2024
    ## [2.2.0](v2.1.0...v2.2.0) (2024-07-11)
    
    ### 🚀 Features
    
    * **api-client:** Added API Client package ([#346](#346)) ([6734e1e](6734e1e))
    * **api:** Updated API key ([fbac312](fbac312))
    * **platform:** View [secure]s ([#313](#313)) ([97c4541](97c4541))
    * **web:** Add Pricing Page ([#243](#243)) ([2c7f1d6](2c7f1d6))
    
    ### 📚 Documentation
    
    * **cli:** Added docs for the CLI package ([#329](#329)) ([edad166](edad166))
    * **cli:** Added usage docs ([#330](#330)) ([b6963d5](b6963d5))
    * Update Discord link ([871b6cd](871b6cd))
    * Update README.md ([e66fcd2](e66fcd2))
    * **web:** Add documentation about our web package ([#268](#268)) ([3d848e7](3d848e7))
    
    ### 🔧 Miscellaneous Chores
    
    * **api:** Updated response types in environment service ([b8a3ddd](b8a3ddd))
    * **ci:** Added release scripts for platform and api ([02dae60](02dae60))
    * **CI:** Updated action plugin versions ([88bb317](88bb317))
    * **CI:** Updated pnpm version in CI file ([2692e88](2692e88))
    * **platform:** Fixed env parsing in platform ([d6ffafa](d6ffafa))
    * **web:** Update Terms and Conditions and Privacy Policy ([#282](#282)) ([d621dcb](d621dcb))
    
    ### 🔨 Code Refactoring
    
    * **api:** Update [secure] and variable fetching endpoints ([7d9acd0](7d9acd0))
    * **cli:** Refactored profile commands into readable blocks ([#331](#331)) ([4a8a089](4a8a089))
    * **cli:** Updated configuration commands and mechanism ([#310](#310)) ([9079b6d](9079b6d))
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    DOCS: Add documentation about our web package Add docs for running the web locally
    3 participants