Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): Add Pricing Page #243

Merged
merged 39 commits into from
Jun 27, 2024
Merged

feat(web): Add Pricing Page #243

merged 39 commits into from
Jun 27, 2024

Conversation

HarshPatel5940
Copy link
Contributor

@HarshPatel5940 HarshPatel5940 commented May 27, 2024 •
edited
Loading

Description

Making the pricing page.

Fixes #227

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

@HarshPatel5940 @rajdip-b
feat(web): add pricing page
f1ec7ef 
* added basic title
@HarshPatel5940
chore(deps): remove millionjs
1a05e99 
* because it uses xycolors which is breaking the installation
@HarshPatel5940
feat(web): add tabs in pricing page
73adbd5
@HarshPatel5940
Copy link
Contributor Author

Some progress on the page. Taking a bit longer cause i am not completely available

image

image

image

@HarshPatel5940 HarshPatel5940 changed the title [WIP] feat(web): Add Pricing Page feat(web): Add Pricing Page Jun 1, 2024
@HarshPatel5940 HarshPatel5940 marked this pull request as ready for review June 1, 2024 07:34
@codiumai-pr-agent-free CodiumAI PR-Agent (Free)
Copy link
Contributor

Failed to generate code suggestions for PR

@rajdip-b
Copy link
Member

rajdip-b commented Jun 1, 2024

This looks good so far!

@HarshPatel5940
Copy link
Contributor Author

This looks good so far!

Good to know 👌

Tomorrow I will look into the "see all features" thing

@rajdip-b
Copy link
Member

rajdip-b commented Jun 5, 2024

Hey @HarshPatel5940, is this up for review?

@HarshPatel5940
Copy link
Contributor Author

HarshPatel5940 commented Jun 17, 2024 •
edited
Loading

I think the work looks clean, here are some final suggestions from my end:

  • Make it responsive (don't want it to be absolute!)

Which part? I checked the cards are responsive.
edit: the only unresponsive part is "see all features" button which i commented out, so someone else can pick it up.

  • There are some errors in the enterprise pricing bullets.

Oh yes, that was fixed with latest commit, let share a updated SS

  • The word "Unlimited" has a small "u" in some places.

this as well, in the latest commit.

  • We can skip "See All Features" for now, and just put in the other fields directly in there.

Thank you bosss.

  • You can get rid of "Space" thing.

Okay, noted.

  • Remove that "Workspace" quotation from the top line. Ideally, we would like our users to have 2 free workspaces (which they can upgrade anytime) at max. The other workspaces need to have a plan associated with them. It would be nice if you can include this as a note somewhere.

@kriptonian1 Please help me with the creativity part :P

@HarshPatel5940
Copy link
Contributor Author

@rajdip-b this is the updated SS. What do you think?

  • Removed "space"
  • renamed "research" to "Features"

image

@rajdip-b
Copy link
Member

This looks perfect!!

Which part? I checked the cards are responsive.
edit: the only unresponsive part is "see all features" button which i commented out, so someone else can pick it up.

I thought it was unresponsive since you mentioned! Let me know when you think it is finished, I'd like to test it from my end aswell.

@HarshPatel5940
Copy link
Contributor Author

I thought it was unresponsive since you mentioned! Let me know when you think it is finished, I'd like to test it from my end aswell.

Ahh ok! As soon as I get yearly fees data, i will implement the tabs as well and I guess we can proceed to merge this PR (keeping the "see all feature" for a later day/PR.

@rajdip-b
Copy link
Member

Sure! That's the idea.

@rajdip-b
Copy link
Member

@HarshPatel5940 hey bro can you please update this PR :) ?

@HarshPatel5940
Copy link
Contributor Author

@HarshPatel5940 hey bro can you please update this PR :) ?

Updated tabs to be responsive!

kriptonian1
kriptonian1 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@kriptonian1 kriptonian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just some few changes, after which I think it will be good to go

apps/web/src/types/pricing.ts Outdated Show resolved Hide resolved
apps/web/src/app/(main)/pricing/page.tsx Outdated Show resolved Hide resolved
@kriptonian1
Copy link
Contributor

@HarshPatel5940 Have you figured out how to do show more button, or will we need some help

@rajdip-b
Copy link
Member

@HarshPatel5940 Have you figured out how to do show more button, or will we need some help

We are skipping that for the moment and listing all the features in the card itself. We will figure something out after this gets merged.

kriptonian1
kriptonian1 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@kriptonian1 kriptonian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kriptonian1
Copy link
Contributor

@HarshPatel5940 can you fix the merge conflict

@HarshPatel5940
Copy link
Contributor Author

@HarshPatel5940 can you fix the merge conflict

Ok, doing it.

@rajdip-b rajdip-b merged commit cb0f301 into keyshade-xyz:develop Jun 27, 2024
4 checks passed
yogesh1801 pushed a commit to yogesh1801/keyshade that referenced this pull request Jun 29, 2024
@HarshPatel5940 @kriptonian1
@rajdip-b @yogesh1801
feat(web): Add Pricing Page (keyshade-xyz#243)
fdba445 
Co-authored-by: Sawan Bhattacharya <74916308+kriptonian1@users.noreply.github.com>
Co-authored-by: Rajdip Bhattacharya <agentR47@gmail.com>
rajdip-b added a commit that referenced this pull request Jul 11, 2024
@HarshPatel5940 @kriptonian1 @rajdip-b
feat(web): Add Pricing Page (#243)
2c7f1d6 
Co-authored-by: Sawan Bhattacharya <74916308+kriptonian1@users.noreply.github.com>
Co-authored-by: Rajdip Bhattacharya <agentR47@gmail.com>
rajdip-b pushed a commit that referenced this pull request Jul 11, 2024
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
f057445 
## [2.2.0](v2.1.0...v2.2.0) (2024-07-11)

### 🚀 Features

* **api-client:** Added API Client package ([#346](#346)) ([6734e1e](6734e1e))
* **api:** Updated API key ([fbac312](fbac312))
* **platform:** View [secure]s ([#313](#313)) ([97c4541](97c4541))
* **web:** Add Pricing Page ([#243](#243)) ([2c7f1d6](2c7f1d6))

### 📚 Documentation

* **cli:** Added docs for the CLI package ([#329](#329)) ([edad166](edad166))
* **cli:** Added usage docs ([#330](#330)) ([b6963d5](b6963d5))
* Update Discord link ([871b6cd](871b6cd))
* Update README.md ([e66fcd2](e66fcd2))
* **web:** Add documentation about our web package ([#268](#268)) ([3d848e7](3d848e7))

### 🔧 Miscellaneous Chores

* **api:** Updated response types in environment service ([b8a3ddd](b8a3ddd))
* **ci:** Added release scripts for platform and api ([02dae60](02dae60))
* **CI:** Updated action plugin versions ([88bb317](88bb317))
* **CI:** Updated pnpm version in CI file ([2692e88](2692e88))
* **platform:** Fixed env parsing in platform ([d6ffafa](d6ffafa))
* **web:** Update Terms and Conditions and Privacy Policy ([#282](#282)) ([d621dcb](d621dcb))

### 🔨 Code Refactoring

* **api:** Update [secure] and variable fetching endpoints ([7d9acd0](7d9acd0))
* **cli:** Refactored profile commands into readable blocks ([#331](#331)) ([4a8a089](4a8a089))
* **cli:** Updated configuration commands and mechanism ([#310](#310)) ([9079b6d](9079b6d))
rajdip-b pushed a commit that referenced this pull request Jul 11, 2024
@semantic-release-bot @rajdip-b
chore(release): 2.2.0 [skip ci]
5e18dda 
## [2.2.0](v2.1.0...v2.2.0) (2024-07-11)

### 🚀 Features

* **api-client:** Added API Client package ([#346](#346)) ([6734e1e](6734e1e))
* **api:** Updated API key ([fbac312](fbac312))
* **platform:** View [secure]s ([#313](#313)) ([97c4541](97c4541))
* **web:** Add Pricing Page ([#243](#243)) ([2c7f1d6](2c7f1d6))

### 📚 Documentation

* **cli:** Added docs for the CLI package ([#329](#329)) ([edad166](edad166))
* **cli:** Added usage docs ([#330](#330)) ([b6963d5](b6963d5))
* Update Discord link ([871b6cd](871b6cd))
* Update README.md ([e66fcd2](e66fcd2))
* **web:** Add documentation about our web package ([#268](#268)) ([3d848e7](3d848e7))

### 🔧 Miscellaneous Chores

* **api:** Updated response types in environment service ([b8a3ddd](b8a3ddd))
* **ci:** Added release scripts for platform and api ([02dae60](02dae60))
* **CI:** Updated action plugin versions ([88bb317](88bb317))
* **CI:** Updated pnpm version in CI file ([2692e88](2692e88))
* **platform:** Fixed env parsing in platform ([d6ffafa](d6ffafa))
* **web:** Update Terms and Conditions and Privacy Policy ([#282](#282)) ([d621dcb](d621dcb))

### 🔨 Code Refactoring

* **api:** Update [secure] and variable fetching endpoints ([7d9acd0](7d9acd0))
* **cli:** Refactored profile commands into readable blocks ([#331](#331)) ([4a8a089](4a8a089))
* **cli:** Updated configuration commands and mechanism ([#310](#310)) ([9079b6d](9079b6d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriptonian1 kriptonian1 kriptonian1 approved these changes

@rajdip-b rajdip-b rajdip-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WEB: Add pricing page
4 participants
@HarshPatel5940 @rajdip-b @kriptonian1 @Ritika1705