Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): Added docs for the CLI package #329

Merged
merged 2 commits into from
Jul 7, 2024
Merged

docs(cli): Added docs for the CLI package #329

merged 2 commits into from
Jul 7, 2024

Conversation

rajdip-b
Copy link
Member

@rajdip-b rajdip-b commented Jul 7, 2024

PR Type

Documentation, Enhancement


Description

  • Added a default value for the --overwrite option in the InitCommand.
  • Updated SUMMARY.md to include links to new CLI documentation sections and reordered some sections for better organization.
  • Added a link to the new CLI documentation in the design documentation README.
  • Created a detailed design document for the CLI, including stack, structure, BaseCommand class, and best practices.
  • Enhanced web design documentation with descriptions and improved formatting.
  • Updated local running instructions to include CLI and Web.
  • Added a new document detailing how to run the CLI locally.

Changes walkthrough 📝

Relevant files
Enhancement
init.command.ts
Add default value for `--overwrite` option in InitCommand

apps/cli/src/commands/init.command.ts

  • Added a default value for the --overwrite option in the CLI command.
  • +2/-1     
    Documentation
    SUMMARY.md
    Update SUMMARY.md to include CLI documentation                     

    docs/SUMMARY.md

  • Added links to new CLI documentation sections.
  • Reordered some sections for better organization.
  • +4/-1     
    README.md
    Add CLI link to design documentation README                           

    docs/contributing-to-keyshade/design-of-our-code/README.md

    • Added a link to the new CLI documentation.
    +3/-1     
    cli.md
    Add detailed design documentation for CLI                               

    docs/contributing-to-keyshade/design-of-our-code/cli.md

  • Created a new document detailing the design of the CLI.
  • Included sections on stack, structure, BaseCommand class, and best
    practices.
  • +84/-0   
    web.md
    Enhance web design documentation with descriptions and formatting

    docs/contributing-to-keyshade/design-of-our-code/web.md

  • Added a description front matter.
  • Improved formatting and added missing sections.
  • +9/-1     
    README.md
    Update local running instructions to include CLI and Web 

    docs/contributing-to-keyshade/running-things-locally/README.md

    • Added links to new CLI and Web running instructions.
    +2/-0     
    running-the-cli.md
    Add instructions for running the CLI locally                         

    docs/contributing-to-keyshade/running-things-locally/running-the-cli.md

    • Created a new document detailing how to run the CLI locally.
    +22/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Add a step to install dependencies before starting development

    Include a step to install dependencies before starting the development process to avoid
    missing dependencies issues.

    docs/contributing-to-keyshade/running-things-locally/running-the-cli.md [7]

    +- Install dependencies:
    +  ```bash
    +  pnpm install
    +  ```
     - Start developing the code
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Including a step to install dependencies is crucial to ensure that all necessary packages are available before development begins, preventing potential issues.

    8
    Maintainability
    Add a note to ensure correct import of the COMMANDS variable in index.ts

    Add a note to ensure that the COMMANDS variable is imported correctly in index.ts to avoid
    runtime errors.

    docs/contributing-to-keyshade/design-of-our-code/cli.md [50]

    -Once you have finished working on the commands, you would need to add the command to the `COMMANDS` variable in `index.ts`.
    +Once you have finished working on the commands, you would need to add the command to the `COMMANDS` variable in `index.ts`. Ensure that the `COMMANDS` variable is imported correctly to avoid runtime errors.
     
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Adding a note about the correct import of the COMMANDS variable is a good practice to prevent runtime errors and improve maintainability.

    7
    Enhancement
    Add a brief description of the components directory

    Add a brief description of the components directory to maintain consistency with other
    directory descriptions.

    docs/contributing-to-keyshade/design-of-our-code/web.md [46]

    -- **components**: Reusable pieces used in the app.
    +- **components**: Contains reusable pieces used in the app, such as UI components and widgets.
     
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: Enhancing the description of the components directory improves documentation clarity and consistency with other directory descriptions.

    6

    @rajdip-b rajdip-b merged commit 288384c into develop Jul 7, 2024
    5 checks passed
    @rajdip-b rajdip-b deleted the docs/cli branch July 7, 2024 12:13
    rajdip-b pushed a commit that referenced this pull request Jul 11, 2024
    ## [2.2.0](v2.1.0...v2.2.0) (2024-07-11)
    
    ### 🚀 Features
    
    * **api-client:** Added API Client package ([#346](#346)) ([6734e1e](6734e1e))
    * **api:** Updated API key ([fbac312](fbac312))
    * **platform:** View [secure]s ([#313](#313)) ([97c4541](97c4541))
    * **web:** Add Pricing Page ([#243](#243)) ([2c7f1d6](2c7f1d6))
    
    ### 📚 Documentation
    
    * **cli:** Added docs for the CLI package ([#329](#329)) ([edad166](edad166))
    * **cli:** Added usage docs ([#330](#330)) ([b6963d5](b6963d5))
    * Update Discord link ([871b6cd](871b6cd))
    * Update README.md ([e66fcd2](e66fcd2))
    * **web:** Add documentation about our web package ([#268](#268)) ([3d848e7](3d848e7))
    
    ### 🔧 Miscellaneous Chores
    
    * **api:** Updated response types in environment service ([b8a3ddd](b8a3ddd))
    * **ci:** Added release scripts for platform and api ([02dae60](02dae60))
    * **CI:** Updated action plugin versions ([88bb317](88bb317))
    * **CI:** Updated pnpm version in CI file ([2692e88](2692e88))
    * **platform:** Fixed env parsing in platform ([d6ffafa](d6ffafa))
    * **web:** Update Terms and Conditions and Privacy Policy ([#282](#282)) ([d621dcb](d621dcb))
    
    ### 🔨 Code Refactoring
    
    * **api:** Update [secure] and variable fetching endpoints ([7d9acd0](7d9acd0))
    * **cli:** Refactored profile commands into readable blocks ([#331](#331)) ([4a8a089](4a8a089))
    * **cli:** Updated configuration commands and mechanism ([#310](#310)) ([9079b6d](9079b6d))
    rajdip-b pushed a commit that referenced this pull request Jul 11, 2024
    ## [2.2.0](v2.1.0...v2.2.0) (2024-07-11)
    
    ### 🚀 Features
    
    * **api-client:** Added API Client package ([#346](#346)) ([6734e1e](6734e1e))
    * **api:** Updated API key ([fbac312](fbac312))
    * **platform:** View [secure]s ([#313](#313)) ([97c4541](97c4541))
    * **web:** Add Pricing Page ([#243](#243)) ([2c7f1d6](2c7f1d6))
    
    ### 📚 Documentation
    
    * **cli:** Added docs for the CLI package ([#329](#329)) ([edad166](edad166))
    * **cli:** Added usage docs ([#330](#330)) ([b6963d5](b6963d5))
    * Update Discord link ([871b6cd](871b6cd))
    * Update README.md ([e66fcd2](e66fcd2))
    * **web:** Add documentation about our web package ([#268](#268)) ([3d848e7](3d848e7))
    
    ### 🔧 Miscellaneous Chores
    
    * **api:** Updated response types in environment service ([b8a3ddd](b8a3ddd))
    * **ci:** Added release scripts for platform and api ([02dae60](02dae60))
    * **CI:** Updated action plugin versions ([88bb317](88bb317))
    * **CI:** Updated pnpm version in CI file ([2692e88](2692e88))
    * **platform:** Fixed env parsing in platform ([d6ffafa](d6ffafa))
    * **web:** Update Terms and Conditions and Privacy Policy ([#282](#282)) ([d621dcb](d621dcb))
    
    ### 🔨 Code Refactoring
    
    * **api:** Update [secure] and variable fetching endpoints ([7d9acd0](7d9acd0))
    * **cli:** Refactored profile commands into readable blocks ([#331](#331)) ([4a8a089](4a8a089))
    * **cli:** Updated configuration commands and mechanism ([#310](#310)) ([9079b6d](9079b6d))
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant