Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-client): Create controller for Project module #370

Merged
merged 20 commits into from
Aug 24, 2024

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Jul 27, 2024

Description

Api client controller for project

Fixes #350

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

Copy link
Contributor

Failed to generate code suggestions for PR

Copy link
Member

@rajdip-b rajdip-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure looks good.

Copy link
Member

@rajdip-b rajdip-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would also need to include tests

packages/api-client/src/controllers/project/project.ts Outdated Show resolved Hide resolved
packages/api-client/src/controllers/project/project.ts Outdated Show resolved Hide resolved
packages/api-client/src/controllers/project/project.ts Outdated Show resolved Hide resolved
packages/api-client/src/types/project.types.d.ts Outdated Show resolved Hide resolved
packages/api-client/src/controllers/project/project.ts Outdated Show resolved Hide resolved
@rajdip-b rajdip-b added the foss hack Clustering all the curated issues for Foss Hack 2024 label Jul 27, 2024
@vr-varad
Copy link
Contributor Author

@rajdip-b wrote the tests but getting this error any idea why?
RUNS api tests/project.spec.ts
/home/varad/Desktop/keyshade/packages/api-client:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  api-client@1.0.0 test: BACKEND_URL=http://localhost:4200 jest
Exit status 1
 WARN  Local package.json exists, but node_modules missing, did you mean to install?
 ELIFECYCLE  Command failed with exit code 1.
husky - pre-commit script failed (code 1)

@rajdip-b
Copy link
Member

I've pushed an update that fixes this error.

@vr-varad
Copy link
Contributor Author

@rajdip-b the tests are running successfully

@rajdip-b
Copy link
Member

cool! I'll test them and approve it

@rajdip-b rajdip-b merged commit d7bf16b into keyshade-xyz:develop Aug 24, 2024
5 checks passed
rajdip-b added a commit that referenced this pull request Sep 5, 2024
Co-authored-by: vr-varad <varadgupta21#gmail.com>
Co-authored-by: Rajdip Bhattacharya <agentR47@gmail.com>
rajdip-b pushed a commit that referenced this pull request Sep 5, 2024
## [2.4.0](v2.3.0...v2.4.0) (2024-09-05)

### 🚀 Features

* **api-client:** Create controller for Event module ([#399](#399)) ([122df35](122df35))
* **api-client:** Create controller for Integration module ([#397](#397)) ([697d38b](697d38b))
* **api-client:** Create controller for Project module ([#370](#370)) ([fa25866](fa25866))
* **api-client:** Create controller for Secret module ([#396](#396)) ([7e929c0](7e929c0))
* **api-client:** Create controller for Variable module ([#395](#395)) ([3e114d9](3e114d9))
* **api:** Add global search in workspace ([c49962b](c49962b))
* **api:** Add max page size ([#377](#377)) ([ed18eb0](ed18eb0))
* **cli:** Add functionality to operate on Environments ([#324](#324)) ([4c6f3f8](4c6f3f8))
* **cli:** Quit on decryption failure ([#381](#381)) ([1349d15](1349d15))

### 🐛 Bug Fixes

* **api-client:** Fixed broken export ([096df2c](096df2c))
* **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([#408](#408)) ([ab441db](ab441db))
* **cli:** Fixed missing module ([f7a091f](f7a091f))
* **platform:**  Build failure in platform ([#385](#385)) ([90dcb2c](90dcb2c))

### 🔧 Miscellaneous Chores

* Add api client build script and updated CI ([da0e27a](da0e27a))
* **api:** Reorganized import using path alias ([d5befd1](d5befd1))
* **ci:** Update CLI CI name ([8f4c456](8f4c456))
* **cli:** Add Zod validation to parseInput function ([#362](#362)) ([34e6c39](34e6c39))
* Fixed api client tests and rearranged controllers ([1307604](1307604))
* Housekeeping ([c5f1330](c5f1330))
* **platform:** Added strict null check ([072254f](072254f))
* **web:** Added strict null check ([7e12b47](7e12b47))

### 🔨 Code Refactoring

* **api:** Update logic for forking projects ([#398](#398)) ([4cf3838](4cf3838))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foss hack Clustering all the curated issues for Foss Hack 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API-CLIENT: Create controller for Project module
2 participants