feat(api): Add max page size #377

DhairyaMajmudar · 2024-07-27T07:46:26Z

Description

Adding max page size to 30

Fixes #160

Dependencies

N/A

Future Improvements

N/A

Mentions

@rajdip-b

Screenshots of relevant screens

N/A

Developer's checklist

My PR follows the style guidelines of this project
I have performed a self-check on my work

If changes are made in the code:

I have followed the coding guidelines
My changes in code generate no new warnings
My changes are breaking another fix/feature of the project
I have added test cases to show that my feature works
I have added relevant screenshots in my PR
There are no UI/UX issues

Documentation Update

This PR requires an update to the documentation at docs.keyshade.xyz
I have made the necessary updates to the documentation, or no documentation changes are required.

codiumai-pr-agent-free · 2024-07-27T07:46:42Z

Failed to generate code suggestions for PR

apps/api/src/project/service/project.service.ts

rajdip-b · 2024-07-30T05:47:16Z

apps/api/src/workspace/service/workspace.service.ts

@@ -763,7 +763,7 @@ export class WorkspaceService {
    //get all workspaces of user for page with limit
    const items = await this.prisma.workspace.findMany({
      skip: page * limit,
-      take: Math.min(limit, 30),
+      take: Number(limit),


This won't be necessary. Just limit will do.

Done 👍🏻

You would need to pass limitMaxItemsPerPage(limit) in here :(

rajdip-b · 2024-07-30T05:54:55Z

You would also need to send in the max limit in here. I would say, create a util function name limit-max-items-per-page.ts and call that function across all the limits. This way, later on when we need to change the capacity, we only change the function and not all the code.

rajdip-b

For all the files I have the same comments:

Get rid of Number() function
Replace limit: Number(limit), with limit: limitMaxItemsPerPage(limit), in every paginate function call

apps/api/src/api-key/service/api-key.service.ts

DhairyaMajmudar · 2024-07-30T13:10:06Z

For all the files I have the same comments:

* Get rid of `Number()` function

* Replace `limit: Number(limit),` with `limit: limitMaxItemsPerPage(limit),` in every `paginate` function call

sure, and I've to do any changes with page: Number(page), or that's correct ?

rajdip-b

Replace all occurences of page: Number(page) with page,

apps/api/src/environment/service/environment.service.ts

apps/api/src/secret/service/secret.service.ts

apps/api/src/workspace/service/workspace.service.ts

rajdip-b

instead of using page: page, just use page,

rajdip-b · 2024-08-01T05:23:27Z

apps/api/src/workspace/service/workspace.service.ts

@@ -763,7 +763,7 @@ export class WorkspaceService {
    //get all workspaces of user for page with limit
    const items = await this.prisma.workspace.findMany({
      skip: page * limit,
-      take: Math.min(limit, 30),
+      take: Number(limit),


You would need to pass limitMaxItemsPerPage(limit) in here :(

## [2.4.0](v2.3.0...v2.4.0) (2024-09-05) ### 🚀 Features * **api-client:** Create controller for Event module ([#399](#399)) ([122df35](122df35)) * **api-client:** Create controller for Integration module ([#397](#397)) ([697d38b](697d38b)) * **api-client:** Create controller for Project module ([#370](#370)) ([fa25866](fa25866)) * **api-client:** Create controller for Secret module ([#396](#396)) ([7e929c0](7e929c0)) * **api-client:** Create controller for Variable module ([#395](#395)) ([3e114d9](3e114d9)) * **api:** Add global search in workspace ([c49962b](c49962b)) * **api:** Add max page size ([#377](#377)) ([ed18eb0](ed18eb0)) * **cli:** Add functionality to operate on Environments ([#324](#324)) ([4c6f3f8](4c6f3f8)) * **cli:** Quit on decryption failure ([#381](#381)) ([1349d15](1349d15)) ### 🐛 Bug Fixes * **api-client:** Fixed broken export ([096df2c](096df2c)) * **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([#408](#408)) ([ab441db](ab441db)) * **cli:** Fixed missing module ([f7a091f](f7a091f)) * **platform:** Build failure in platform ([#385](#385)) ([90dcb2c](90dcb2c)) ### 🔧 Miscellaneous Chores * Add api client build script and updated CI ([da0e27a](da0e27a)) * **api:** Reorganized import using path alias ([d5befd1](d5befd1)) * **ci:** Update CLI CI name ([8f4c456](8f4c456)) * **cli:** Add Zod validation to parseInput function ([#362](#362)) ([34e6c39](34e6c39)) * Fixed api client tests and rearranged controllers ([1307604](1307604)) * Housekeeping ([c5f1330](c5f1330)) * **platform:** Added strict null check ([072254f](072254f)) * **web:** Added strict null check ([7e12b47](7e12b47)) ### 🔨 Code Refactoring * **api:** Update logic for forking projects ([#398](#398)) ([4cf3838](4cf3838))

## [2.4.0](keyshade-xyz/keyshade@v2.3.0...v2.4.0) (2024-09-05) ### 🚀 Features * **api-client:** Create controller for Event module ([keyshade-xyz#399](keyshade-xyz#399)) ([122df35](keyshade-xyz@122df35)) * **api-client:** Create controller for Integration module ([keyshade-xyz#397](keyshade-xyz#397)) ([697d38b](keyshade-xyz@697d38b)) * **api-client:** Create controller for Project module ([keyshade-xyz#370](keyshade-xyz#370)) ([fa25866](keyshade-xyz@fa25866)) * **api-client:** Create controller for Secret module ([keyshade-xyz#396](keyshade-xyz#396)) ([7e929c0](keyshade-xyz@7e929c0)) * **api-client:** Create controller for Variable module ([keyshade-xyz#395](keyshade-xyz#395)) ([3e114d9](keyshade-xyz@3e114d9)) * **api:** Add global search in workspace ([c49962b](keyshade-xyz@c49962b)) * **api:** Add max page size ([keyshade-xyz#377](keyshade-xyz#377)) ([ed18eb0](keyshade-xyz@ed18eb0)) * **cli:** Add functionality to operate on Environments ([keyshade-xyz#324](keyshade-xyz#324)) ([4c6f3f8](keyshade-xyz@4c6f3f8)) * **cli:** Quit on decryption failure ([keyshade-xyz#381](keyshade-xyz#381)) ([1349d15](keyshade-xyz@1349d15)) ### 🐛 Bug Fixes * **api-client:** Fixed broken export ([096df2c](keyshade-xyz@096df2c)) * **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([keyshade-xyz#408](keyshade-xyz#408)) ([ab441db](keyshade-xyz@ab441db)) * **cli:** Fixed missing module ([f7a091f](keyshade-xyz@f7a091f)) * **platform:** Build failure in platform ([keyshade-xyz#385](keyshade-xyz#385)) ([90dcb2c](keyshade-xyz@90dcb2c)) ### 🔧 Miscellaneous Chores * Add api client build script and updated CI ([da0e27a](keyshade-xyz@da0e27a)) * **api:** Reorganized import using path alias ([d5befd1](keyshade-xyz@d5befd1)) * **ci:** Update CLI CI name ([8f4c456](keyshade-xyz@8f4c456)) * **cli:** Add Zod validation to parseInput function ([keyshade-xyz#362](keyshade-xyz#362)) ([34e6c39](keyshade-xyz@34e6c39)) * Fixed api client tests and rearranged controllers ([1307604](keyshade-xyz@1307604)) * Housekeeping ([c5f1330](keyshade-xyz@c5f1330)) * **platform:** Added strict null check ([072254f](keyshade-xyz@072254f)) * **web:** Added strict null check ([7e12b47](keyshade-xyz@7e12b47)) ### 🔨 Code Refactoring * **api:** Update logic for forking projects ([keyshade-xyz#398](keyshade-xyz#398)) ([4cf3838](keyshade-xyz@4cf3838))

adding max page size

4de8c4a

DhairyaMajmudar requested a review from rajdip-b as a code owner July 27, 2024 07:46

rajdip-b approved these changes Jul 27, 2024

View reviewed changes

apps/api/src/project/service/project.service.ts Outdated Show resolved Hide resolved

rajdip-b added the foss hack Clustering all the curated issues for Foss Hack 2024 label Jul 27, 2024

rajdip-b changed the title ~~fix: Adding max page size~~ feat(api): Add max page size Jul 27, 2024

Merge branch 'develop' into 160

b99b759

rajdip-b reviewed Jul 30, 2024

View reviewed changes

DhairyaMajmudar added 2 commits July 30, 2024 11:17

adding more endpoints

48090a5

removing number

f637ba3

DhairyaMajmudar added 3 commits July 30, 2024 11:52

adding util func and necessary changes

c899519

adding util func and necessary changes

4a6d55a

adding util func and necessary changes

e0d7b49

rajdip-b requested changes Jul 30, 2024

View reviewed changes

apps/api/src/api-key/service/api-key.service.ts Show resolved Hide resolved

DhairyaMajmudar added 2 commits July 30, 2024 20:36

removing number

78efe4c

removing number

2959610

rajdip-b requested changes Jul 30, 2024

View reviewed changes

apps/api/src/environment/service/environment.service.ts Outdated Show resolved Hide resolved

apps/api/src/secret/service/secret.service.ts Outdated Show resolved Hide resolved

apps/api/src/workspace/service/workspace.service.ts Outdated Show resolved Hide resolved

DhairyaMajmudar and others added 2 commits July 31, 2024 23:33

Merge branch 'develop' into 160

0a7e781

minor fixes

b58139c

rajdip-b requested changes Aug 1, 2024

View reviewed changes

removing page

a7cca5f

rajdip-b approved these changes Aug 1, 2024

View reviewed changes

rajdip-b merged commit db5bd4f into keyshade-xyz:develop Aug 1, 2024
4 checks passed

rajdip-b pushed a commit that referenced this pull request Sep 5, 2024

feat(api): Add max page size (#377)

ed18eb0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(api): Add max page size #377

feat(api): Add max page size #377

DhairyaMajmudar commented Jul 27, 2024

codiumai-pr-agent-free bot commented Jul 27, 2024

rajdip-b Jul 30, 2024

DhairyaMajmudar Jul 30, 2024

rajdip-b Aug 1, 2024

rajdip-b commented Jul 30, 2024

rajdip-b left a comment

DhairyaMajmudar commented Jul 30, 2024

rajdip-b left a comment

rajdip-b left a comment

rajdip-b Aug 1, 2024

feat(api): Add max page size #377

feat(api): Add max page size #377

Conversation

DhairyaMajmudar commented Jul 27, 2024

Description

Dependencies

Future Improvements

Mentions

Screenshots of relevant screens

Developer's checklist

Documentation Update

codiumai-pr-agent-free bot commented Jul 27, 2024

rajdip-b Jul 30, 2024

Choose a reason for hiding this comment

DhairyaMajmudar Jul 30, 2024

Choose a reason for hiding this comment

rajdip-b Aug 1, 2024

Choose a reason for hiding this comment

rajdip-b commented Jul 30, 2024

rajdip-b left a comment

Choose a reason for hiding this comment

DhairyaMajmudar commented Jul 30, 2024

rajdip-b left a comment

Choose a reason for hiding this comment

rajdip-b left a comment

Choose a reason for hiding this comment

rajdip-b Aug 1, 2024

Choose a reason for hiding this comment