Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Quit on decryption failure #381

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

Dark-Kernel
Copy link
Contributor

@Dark-Kernel Dark-Kernel commented Jul 27, 2024

Description

Added the --quit-on-decryption-failure option to init command, also added that in ProjectRootConfig

Fixes #294

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

Copy link
Contributor

Failed to generate code suggestions for PR

@rajdip-b rajdip-b changed the title feat(cli): quit on decryption failure feat(cli): Quit on decryption failure Jul 27, 2024
apps/api/package.json Outdated Show resolved Hide resolved
apps/cli/package.json Outdated Show resolved Hide resolved
apps/cli/src/commands/init.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/init.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/init.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/run.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/run.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/run.command.ts Outdated Show resolved Hide resolved
Dark-Kernel added a commit to Dark-Kernel/keyshade that referenced this pull request Jul 28, 2024
@Dark-Kernel
Copy link
Contributor Author

The requested changes have been made, please take a look.

apps/cli/src/commands/run.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/run.command.ts Outdated Show resolved Hide resolved
apps/cli/src/commands/run.command.ts Outdated Show resolved Hide resolved
@rajdip-b
Copy link
Member

@Dark-Kernel i think you've forgotten to do pnpm i. Can you take this latest pull and do so?

@Dark-Kernel
Copy link
Contributor Author

@Dark-Kernel i think you've forgotten to do pnpm i. Can you take this latest pull and do so?

yeah, in progress

@Dark-Kernel
Copy link
Contributor Author

done.

@rajdip-b rajdip-b merged commit fedc43b into keyshade-xyz:develop Jul 29, 2024
5 checks passed
rajdip-b pushed a commit that referenced this pull request Sep 5, 2024
rajdip-b pushed a commit that referenced this pull request Sep 5, 2024
## [2.4.0](v2.3.0...v2.4.0) (2024-09-05)

### 🚀 Features

* **api-client:** Create controller for Event module ([#399](#399)) ([122df35](122df35))
* **api-client:** Create controller for Integration module ([#397](#397)) ([697d38b](697d38b))
* **api-client:** Create controller for Project module ([#370](#370)) ([fa25866](fa25866))
* **api-client:** Create controller for Secret module ([#396](#396)) ([7e929c0](7e929c0))
* **api-client:** Create controller for Variable module ([#395](#395)) ([3e114d9](3e114d9))
* **api:** Add global search in workspace ([c49962b](c49962b))
* **api:** Add max page size ([#377](#377)) ([ed18eb0](ed18eb0))
* **cli:** Add functionality to operate on Environments ([#324](#324)) ([4c6f3f8](4c6f3f8))
* **cli:** Quit on decryption failure ([#381](#381)) ([1349d15](1349d15))

### 🐛 Bug Fixes

* **api-client:** Fixed broken export ([096df2c](096df2c))
* **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([#408](#408)) ([ab441db](ab441db))
* **cli:** Fixed missing module ([f7a091f](f7a091f))
* **platform:**  Build failure in platform ([#385](#385)) ([90dcb2c](90dcb2c))

### 🔧 Miscellaneous Chores

* Add api client build script and updated CI ([da0e27a](da0e27a))
* **api:** Reorganized import using path alias ([d5befd1](d5befd1))
* **ci:** Update CLI CI name ([8f4c456](8f4c456))
* **cli:** Add Zod validation to parseInput function ([#362](#362)) ([34e6c39](34e6c39))
* Fixed api client tests and rearranged controllers ([1307604](1307604))
* Housekeeping ([c5f1330](c5f1330))
* **platform:** Added strict null check ([072254f](072254f))
* **web:** Added strict null check ([7e12b47](7e12b47))

### 🔨 Code Refactoring

* **api:** Update logic for forking projects ([#398](#398)) ([4cf3838](4cf3838))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Decrypt encrypted secrets before setting them in the environment
3 participants