Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): Build failure in platform #385

Merged
merged 7 commits into from
Aug 24, 2024
Merged

fix(platform): Build failure in platform #385

merged 7 commits into from
Aug 24, 2024

Conversation

DhairyaMajmudar
Copy link
Contributor

@DhairyaMajmudar DhairyaMajmudar commented Jul 27, 2024 •
edited by rajdip-b
Loading

User description

Description

removing several build fails from platform app

Fixes #384

Dependencies

N/A

Future Improvements

There are still some build fails exist in the codebase

image

Mentions

@rajdip-b

Screenshots of relevant screens

N/A

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

Bug fix, Enhancement

Description

  • Fixed the return type and response format in the health API route to ensure proper response handling.
  • Enhanced type safety and readability in the Command component by adding type annotations and removing unnecessary type assertions.

Changes walkthrough 📝

Relevant files
Bug fix
route.ts
Fix return type and response format in health API route   

apps/platform/src/app/api/health/route.ts

  • Changed return type of GET function to NextResponse
  • Updated response format to JSON with status 200
    		•  +1/-1     
    Enhancement
    command.tsx
    Enhance type safety and readability in Command component 

    apps/platform/src/components/ui/command.tsx

  • Added type annotations for React.forwardRef components
  • Removed unnecessary type assertions
  • Improved type safety and readability
    		•  +30/-29 

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @codiumai-pr-agent-free CodiumAI PR-Agent (Free)
    Copy link
    Contributor

    Failed to generate code suggestions for PR

    @rajdip-b rajdip-b changed the title fix(platform): removing build fails from platform fix(platform): Build failure in platform Jul 27, 2024
    @rajdip-b
    Copy link
    Member

    @DhairyaMajmudar you can fix these one by one as time permits. We would be glad to have an error free code. Please ping @kriptonian1 in case you need some help since he is the code owner.

    @DhairyaMajmudar
    Copy link
    Contributor Author

    Sure thing 🚀

    @kriptonian1
    Copy link
    Contributor

    Hey @DhairyaMajmudar this is issue are related to shadcn ui. So maybe you can refer to this issue shadcn-ui/ui#3143 in which they have suggested a fix

    @rajdip-b rajdip-b marked this pull request as draft July 29, 2024 13:08
    @DhairyaMajmudar DhairyaMajmudar deleted the 384 branch July 30, 2024 05:39
    @DhairyaMajmudar DhairyaMajmudar restored the 384 branch July 30, 2024 05:40
    @DhairyaMajmudar
    Copy link
    Contributor Author

    @kriptonian1 types failures are fixed, but still facing errors due to usage of locastorage in https://github.com/keyshade-xyz/keyshade/blob/develop/apps/platform/src/app/(main)/page.tsx#L60 and https://github.com/keyshade-xyz/keyshade/blob/develop/apps/platform/src/lib/workspace-storage.ts#L6 files, Below are the error logs:

    platform:build: cache miss, executing 3caca622bba58b30
platform:build: 
platform:build: > platform@1.0.0 build /home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform
platform:build: > next build
platform:build: 
platform:build:  ✓ Creating an optimized production build 
platform:build:  ✓ Compiled successfully
platform:build:  ✓ Linting and checking validity of types 
platform:build:  ✓ Collecting page data 
   Generating static pages (0/11)  [=   ]ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/settings". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/teams". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:8151)
platform:build:     at Combobox (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform/.next/server/chunks/159.js:1:9778)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build:  ✓ Generating static pages (11/11) 
platform:build: 
platform:build: > Export encountered errors on following paths:
platform:build:         /(main)/page: /
platform:build:         /(main)/settings/@billing/page: /settings
platform:build:         /(main)/teams/page: /teams
platform:build:  ELIFECYCLE  Command failed with exit code 1.
platform:build: ERROR: command finished with error: command (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform) /home/dhairya/.nvm/versions/node/v22.2.0/bin/pnpm run build exited (1)
platform#build: command (/home/dhairya/Desktop/FOSS_Hack'24/keyshade/apps/platform) /home/dhairya/.nvm/versions/node/v22.2.0/bin/pnpm run build exited (1)

 Tasks:    0 successful, 1 total
Cached:    0 cached, 1 total
  Time:    7.054s 
Failed:    platform#build

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Command failed with exit code 1.

    cc: @rajdip-b

    @kriptonian1
    Copy link
    Contributor

    you can refer to this to fix it, but do give it a check if it is breaking something or not

    @DhairyaMajmudar
    Copy link
    Contributor Author

    you can refer to this to fix it, but do give it a check if it is breaking something or not

    * https://medium.com/@zamin_mirzad/how-to-fix-localstorage-is-not-defined-in-next-js-b237498d12ce

* https://sentry.io/answers/referenceerror-localstorage-is-not-defined-in-next-js/

* https://stackoverflow.com/questions/76070793/localstorage-is-not-defined-in-next-js

    useEffect can be a solution but locastorage is used in utility files, so an alternative solution must be there to fix this

    Let's merge this PR to fix other build errors. And do required changes to fix localstorage problem in another PR

    @DhairyaMajmudar DhairyaMajmudar marked this pull request as ready for review August 9, 2024 13:55
    @codiumai-pr-agent-free CodiumAI PR-Agent (Free)
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Function Return Type
    The function GET was changed from returning unknown to NextResponse. Ensure that this change aligns with the expected usage and does not introduce type mismatches elsewhere in the application.

    Type Annotations
    Added type annotations and removed unnecessary type assertions in several components (Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandSeparator, CommandItem). Review these changes for consistency and correctness of type usage.

    @codiumai-pr-agent-free CodiumAI PR-Agent (Free)
    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Performance
    Use memoization to improve component performance

    Consider using memoization for the Command component to prevent unnecessary
    re-renders and improve performance.

    apps/platform/src/components/ui/command.tsx [8-20]

    -const Command = React.forwardRef<
+const Command = React.memo(React.forwardRef<
   React.ElementRef<typeof CommandPrimitive>,
   React.ComponentPropsWithoutRef<typeof CommandPrimitive>
 >(({ className, ...props }, ref) => (
   <CommandPrimitive
     className={cn(
       'flex h-full w-full flex-col overflow-hidden rounded-md bg-[#161819] text-white dark:bg-zinc-950 dark:text-zinc-50',
       className
     )}
     ref={ref}
     {...props}
   />
-))
+)))
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Using memoization can significantly improve performance by preventing unnecessary re-renders, which is particularly beneficial for frequently rendered components.

    		9
    Best practice
    Add explicit return type annotations to the function

    Consider adding explicit type annotations for the return type of the GET function to
    enhance code readability and maintainability.

    apps/platform/src/app/api/health/route.ts [3-5]

    +export function GET(): NextResponse {
+  return NextResponse.json({ message: 'Hello World' }, { status: 200 })
+}
 
-
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Adding explicit return type annotations improves code readability and maintainability, making it clear what the function is expected to return.

    		8
    Possible bug
    Ensure className is always a string

    Ensure that the className prop is always defined as a string to avoid potential
    runtime errors or unexpected behaviors.

    apps/platform/src/components/ui/command.tsx [12-19]

     <CommandPrimitive
   className={cn(
     'flex h-full w-full flex-col overflow-hidden rounded-md bg-[#161819] text-white dark:bg-zinc-950 dark:text-zinc-50',
-    className
+    className || ''
   )}
   ref={ref}
   {...props}
 />
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Ensuring that className is always a string can prevent potential runtime errors or unexpected behaviors, which is a good practice for robustness.

    		7
    Enhancement
    Use destructuring for props in the component

    Use destructuring to handle props more cleanly in the component definition.

    apps/platform/src/components/ui/command.tsx [8-20]

    ->(({ className, ...props }, ref) => (
+>(({ className, children, ...otherProps }, ref) => (
   <CommandPrimitive
     className={cn(
       'flex h-full w-full flex-col overflow-hidden rounded-md bg-[#161819] text-white dark:bg-zinc-950 dark:text-zinc-50',
       className
     )}
     ref={ref}
-    {...props}
-  />
+    {...otherProps}
+  >
+    {children}
+  </CommandPrimitive>
 ))
    • Apply this suggestion
    Suggestion importance[1-10]: 6

    Why: Using destructuring for props can make the code cleaner and more readable, but it is a minor enhancement and not crucial for functionality.

    		6

    @rajdip-b
    Copy link
    Member

    rajdip-b commented Aug 9, 2024

    you can refer to this to fix it, but do give it a check if it is breaking something or not

    * https://medium.com/@zamin_mirzad/how-to-fix-localstorage-is-not-defined-in-next-js-b237498d12ce

* https://sentry.io/answers/referenceerror-localstorage-is-not-defined-in-next-js/

* https://stackoverflow.com/questions/76070793/localstorage-is-not-defined-in-next-js

    useEffect can be a solution but locastorage is used in utility files, so an alternative solution must be there to fix this

    Let's merge this PR to fix other build errors. And do required changes to fix localstorage problem in another PR

    Thats good to hear! We will be using jotai anyways because of its clean API.

    @rajdip-b
    Copy link
    Member

    rajdip-b commented Aug 9, 2024 •
    edited
    Loading 

    pnpm build:platform

> keyshade-xyz@2.3.0 build:platform /home/raj/oss/keyshade.xyz/keyshade-xyz
> turbo run build --filter=platform

╭───────────────────────────────────────────────────────────────────────╮
│                                                                       │
│                  Update available v1.13.4 ≫ v2.0.12                   │
│    Changelog: https://github.com/vercel/turbo/releases/tag/v2.0.12    │
│           Run "npx @turbo/codemod@latest update" to update            │
│                                                                       │
│        Follow @turborepo for updates: https://x.com/turborepo         │
╰───────────────────────────────────────────────────────────────────────╯
• Packages in scope: platform
• Running build in 1 packages
• Remote caching disabled
platform:build: cache miss, executing b88efbf409a1557c
platform:build: 
platform:build: > platform@1.0.0 build /home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform
platform:build: > next build
platform:build: 
platform:build:  ✓ Creating an optimized production build 
platform:build:  ✓ Compiled successfully
platform:build:  ✓ Linting and checking validity of types 
platform:build:  ✓ Collecting page data 
   Generating static pages (0/11)  [=   ]ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/settings". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build: 
platform:build: Error occurred prerendering page "/teams". Read more: https://nextjs.org/docs/messages/prerender-error
platform:build: ReferenceError: localStorage is not defined
platform:build:     at getCurrentWorkspace (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:8158)
platform:build:     at Combobox (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform/.next/server/chunks/935.js:1:9785)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:36421)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:49347)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52524)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at ng (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:54569)
platform:build:     at ny (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:52770)
platform:build:     at nv (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:55162)
platform:build:     at nh (/home/raj/oss/keyshade.xyz/keyshade-xyz/node_modules/.pnpm/next@13.5.6_@babel+core@7.25.2_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:27:46622)
platform:build:  ✓ Generating static pages (11/11) 
platform:build: 
platform:build: > Export encountered errors on following paths:
platform:build: 	/(main)/page: /
platform:build: 	/(main)/settings/@profile/page: /settings
platform:build: 	/(main)/teams/page: /teams
platform:build:  ELIFECYCLE  Command failed with exit code 1.
platform:build: ERROR: command finished with error: command (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform) /home/raj/.local/share/pnpm/pnpm run build exited (1)
platform#build: command (/home/raj/oss/keyshade.xyz/keyshade-xyz/apps/platform) /home/raj/.local/share/pnpm/pnpm run build exited (1)

 Tasks:    0 successful, 1 total
Cached:    0 cached, 1 total
  Time:    35.529s 
Failed:    platform#build

 ERROR  run failed: command  exited (1)
 ELIFECYCLE  Command failed with exit code 1.
 

     
     I got this error @DhairyaMajmudar. Any ideas what might be causing it?

    P.S. can we swap out jotai with local storage? I don't think it makes sense to store workspace data in local storage since we need to add an observer to that. @kriptonian1

    @rajdip-b
    Copy link
    Member

    @DhairyaMajmudar hey bro! Long time since you have put this up. Do we have any changes?

    @DhairyaMajmudar
    Copy link
    Contributor Author

    Hi I've suggested a fix for this here #385 (comment)

    @rajdip-b
    Copy link
    Member

    Moving this convo to discord! I'm still seeing a few errors.

    @rajdip-b
    Copy link
    Member

    Merging this for now, the persisting error needs to swap out local storage with Jotai

    @rajdip-b rajdip-b merged commit 2b54421 into keyshade-xyz:develop Aug 24, 2024
    6 checks passed
    rajdip-b added a commit that referenced this pull request Sep 5, 2024
    @DhairyaMajmudar @rajdip-b
    fix(platform): Build failure in platform (#385)
    90dcb2c 
    Co-authored-by: Rajdip Bhattacharya <agentR47@gmail.com>
    rajdip-b pushed a commit that referenced this pull request Sep 5, 2024
    @semantic-release-bot
    chore(release): 2.4.0 [skip ci]
    c087b32 
    ## [2.4.0](v2.3.0...v2.4.0) (2024-09-05)

### 🚀 Features

* **api-client:** Create controller for Event module ([#399](#399)) ([122df35](122df35))
* **api-client:** Create controller for Integration module ([#397](#397)) ([697d38b](697d38b))
* **api-client:** Create controller for Project module ([#370](#370)) ([fa25866](fa25866))
* **api-client:** Create controller for Secret module ([#396](#396)) ([7e929c0](7e929c0))
* **api-client:** Create controller for Variable module ([#395](#395)) ([3e114d9](3e114d9))
* **api:** Add global search in workspace ([c49962b](c49962b))
* **api:** Add max page size ([#377](#377)) ([ed18eb0](ed18eb0))
* **cli:** Add functionality to operate on Environments ([#324](#324)) ([4c6f3f8](4c6f3f8))
* **cli:** Quit on decryption failure ([#381](#381)) ([1349d15](1349d15))

### 🐛 Bug Fixes

* **api-client:** Fixed broken export ([096df2c](096df2c))
* **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([#408](#408)) ([ab441db](ab441db))
* **cli:** Fixed missing module ([f7a091f](f7a091f))
* **platform:**  Build failure in platform ([#385](#385)) ([90dcb2c](90dcb2c))

### 🔧 Miscellaneous Chores

* Add api client build script and updated CI ([da0e27a](da0e27a))
* **api:** Reorganized import using path alias ([d5befd1](d5befd1))
* **ci:** Update CLI CI name ([8f4c456](8f4c456))
* **cli:** Add Zod validation to parseInput function ([#362](#362)) ([34e6c39](34e6c39))
* Fixed api client tests and rearranged controllers ([1307604](1307604))
* Housekeeping ([c5f1330](c5f1330))
* **platform:** Added strict null check ([072254f](072254f))
* **web:** Added strict null check ([7e12b47](7e12b47))

### 🔨 Code Refactoring

* **api:** Update logic for forking projects ([#398](#398)) ([4cf3838](4cf3838))
    Kiranchaudhary537 pushed a commit to Kiranchaudhary537/keyshade that referenced this pull request Oct 13, 2024
    @DhairyaMajmudar @rajdip-b @Kiranchaudhary537
    fix(platform): Build failure in platform (keyshade-xyz#385)
    1be10d8 
    Co-authored-by: Rajdip Bhattacharya <agentR47@gmail.com>
    Kiranchaudhary537 pushed a commit to Kiranchaudhary537/keyshade that referenced this pull request Oct 13, 2024
    @semantic-release-bot @Kiranchaudhary537
    chore(release): 2.4.0 [skip ci]
    4eb739c 
    ## [2.4.0](keyshade-xyz/keyshade@v2.3.0...v2.4.0) (2024-09-05)

### 🚀 Features

* **api-client:** Create controller for Event module ([keyshade-xyz#399](keyshade-xyz#399)) ([122df35](keyshade-xyz@122df35))
* **api-client:** Create controller for Integration module ([keyshade-xyz#397](keyshade-xyz#397)) ([697d38b](keyshade-xyz@697d38b))
* **api-client:** Create controller for Project module ([keyshade-xyz#370](keyshade-xyz#370)) ([fa25866](keyshade-xyz@fa25866))
* **api-client:** Create controller for Secret module ([keyshade-xyz#396](keyshade-xyz#396)) ([7e929c0](keyshade-xyz@7e929c0))
* **api-client:** Create controller for Variable module ([keyshade-xyz#395](keyshade-xyz#395)) ([3e114d9](keyshade-xyz@3e114d9))
* **api:** Add global search in workspace ([c49962b](keyshade-xyz@c49962b))
* **api:** Add max page size ([keyshade-xyz#377](keyshade-xyz#377)) ([ed18eb0](keyshade-xyz@ed18eb0))
* **cli:** Add functionality to operate on Environments ([keyshade-xyz#324](keyshade-xyz#324)) ([4c6f3f8](keyshade-xyz@4c6f3f8))
* **cli:** Quit on decryption failure ([keyshade-xyz#381](keyshade-xyz#381)) ([1349d15](keyshade-xyz@1349d15))

### 🐛 Bug Fixes

* **api-client:** Fixed broken export ([096df2c](keyshade-xyz@096df2c))
* **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([keyshade-xyz#408](keyshade-xyz#408)) ([ab441db](keyshade-xyz@ab441db))
* **cli:** Fixed missing module ([f7a091f](keyshade-xyz@f7a091f))
* **platform:**  Build failure in platform ([keyshade-xyz#385](keyshade-xyz#385)) ([90dcb2c](keyshade-xyz@90dcb2c))

### 🔧 Miscellaneous Chores

* Add api client build script and updated CI ([da0e27a](keyshade-xyz@da0e27a))
* **api:** Reorganized import using path alias ([d5befd1](keyshade-xyz@d5befd1))
* **ci:** Update CLI CI name ([8f4c456](keyshade-xyz@8f4c456))
* **cli:** Add Zod validation to parseInput function ([keyshade-xyz#362](keyshade-xyz#362)) ([34e6c39](keyshade-xyz@34e6c39))
* Fixed api client tests and rearranged controllers ([1307604](keyshade-xyz@1307604))
* Housekeeping ([c5f1330](keyshade-xyz@c5f1330))
* **platform:** Added strict null check ([072254f](keyshade-xyz@072254f))
* **web:** Added strict null check ([7e12b47](keyshade-xyz@7e12b47))

### 🔨 Code Refactoring

* **api:** Update logic for forking projects ([keyshade-xyz#398](keyshade-xyz#398)) ([4cf3838](keyshade-xyz@4cf3838))
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rajdip-b rajdip-b rajdip-b approved these changes

    @kriptonian1 kriptonian1 Awaiting requested review from kriptonian1 kriptonian1 is a code owner

    Assignees
    No one assigned
    Labels
    Bug fix enhancement Review effort [1-5]: 2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Platform: Build failure of platform app.
    3 participants
    @DhairyaMajmudar @rajdip-b @kriptonian1