chore(cli): Changed objects to classes

[vr-varad]

User description

Description

The following files contained objects of the controller call implementation and I have converted the objects to classes made the functions static, and exported the instance of the class.

Fixes #299

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in the future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

• My PR follows the style guidelines of this project
• I have performed a self-check on my work

If changes are made in the code:

• I have followed the coding guidelines
• My changes in code generate no new warnings
• My changes are breaking another fix/feature of the project
• I have added test cases to show that my feature works
• I have added relevant screenshots in my PR
• There are no UI/UX issues

Documentation Update

• This PR requires an update to the documentation at docs.keyshade.xyz
• I have made the necessary updates to the documentation, or no documentation changes are required.

---

PR Type

Enhancement

---

Description

• Converted AuthController, SecretController, and VariableController objects to classes.
• Made the main methods in each controller (checkApiKeyValidity, fetchSecrets, fetchVariables) static.
• Exported instances of the newly created classes.

---

Changes walkthrough 📝

Relevant files

Enhancement

auth.ts Refactor AuthController to use class with static methods  apps/cli/src/http/auth.ts Converted AuthController object to AuthControllerClass class. Made checkApiKeyValidity a static method. Exported an instance of AuthControllerClass. +18/-16  secret.ts Refactor SecretController to use class with static methods apps/cli/src/http/secret.ts Converted SecretController object to SecretControllerClass class. Made fetchSecrets a static method. Exported an instance of SecretControllerClass. +4/-2      variable.ts Refactor VariableController to use class with static methods apps/cli/src/http/variable.ts Converted VariableController object to VariableControllerClass class. Made fetchVariables a static method. Exported an instance of VariableControllerClass. +4/-2

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The conversion of objects to classes and making methods static could potentially alter the behavior if the methods were previously relying on instance-specific data. Ensure that these methods are indeed suitable to be static and do not require any instance-specific state.
	Refactoring Scope: Ensure that all parts of the application that were using these controllers have been updated to use the new class instances instead of the old object references.

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Add error handling for the fetch operation to improve robustness Implement error handling for the fetch call to manage scenarios where the network request fails or returns an unexpected status. apps/cli/src/http/auth.ts [6-10] -const response = await fetch(`${baseUrl}/api/api-key/access/live-updates`, { - headers: { - 'x-keyshade-token': apiKey +let response; +try { + response = await fetch(`${baseUrl}/api/api-key/access/live-updates`, { + headers: { + 'x-keyshade-token': apiKey + } + }); + if (!response.ok) { + throw new Error(`API key is not valid for ${baseUrl}. Please check the key and try again.`); } -}) +} catch (error) { + Logger.error('Failed to fetch API key validity:', error); + throw error; +} Apply this suggestion Suggestion importance[1-10]: 10 Why: Implementing error handling for the fetch call is crucial for managing scenarios where the network request fails or returns an unexpected status, thereby improving the robustness and reliability of the code.	10
	Add validation for input parameters to prevent unnecessary API calls To ensure that the API key and base URL are not empty before making the request, add validation checks at the beginning of the checkApiKeyValidity method. apps/cli/src/http/auth.ts [4] static async checkApiKeyValidity(baseUrl: string, apiKey: string): Promise<void> { + if (!baseUrl || !apiKey) { + throw new Error('Base URL and API key must be provided.'); + } Apply this suggestion Suggestion importance[1-10]: 9 Why: Adding validation checks for baseUrl and apiKey ensures that the method does not proceed with invalid inputs, which is a best practice to avoid unnecessary API calls and potential errors.	9
Enhancement	Improve error message clarity by including dynamic data Consider using a more descriptive error message that includes the baseUrl to help with debugging. This can be particularly useful in environments where multiple base URLs might be used. apps/cli/src/http/auth.ts [13-15] throw new Error( - 'API key is not valid. Please check the key and try again.' + `API key is not valid for ${baseUrl}. Please check the key and try again.` ) Apply this suggestion Suggestion importance[1-10]: 8 Why: Including the baseUrl in the error message can significantly aid in debugging, especially in environments with multiple base URLs. This is a useful enhancement for clarity.	8

[rajdip-b]

• You don't need to change the name to include Class
• You can get rid of the object initialization since static methods can be accessed without instantiation

[vr-varad]

@rajdip-b Done.