Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3Files Field #1362

Closed
wants to merge 7 commits into from
Closed

S3Files Field #1362

wants to merge 7 commits into from

Conversation

sarriaroman
Copy link

A field to upload multiple files to Amazon S3 using the LocalFiles Field for the UI

@JedWatson
Copy link
Member

@sarriaroman I really appreciate you adding this, is there any chance you'd be interested in contributing to the file-fields branch with myself and @creynders?

We're actually working to get rid of all the specific file fields and replace them with just two:

  • Types.File
  • Types.Files

... and each field can be bound to a storage configuration.

Unfortunately merging this PR at this stage may not be a good idea because it will conflict with our transition to the generic file field, I'm interested in @creynders view on this though...

@JedWatson
Copy link
Member

The issue relating to the File fields is #1222

@sarriaroman
Copy link
Author

@JedWatson I'm agree with the point of view of @creynders but I see the solution as a future solution. I will try to put work to get it faster.

This is a fast solution for a problem I had for a long time ;).

@JedWatson
Copy link
Member

Thanks for the PR @sarriaroman and sorry for leaving it hanging so long. We'll be coming back around to file fields soon with a different approach (cc/ @mxstbr @creynders), so I'm going to close this.

@JedWatson JedWatson closed this May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants