Move createImagesContext inside makeCreateContext

keystonejs · Apr 23, 2021 · 446233b · 446233b
1 parent 4130ce2
commit 446233b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/.changeset/famous-avocados-happen.md b/.changeset/famous-avocados-happen.md
@@ -0,0 +1,5 @@
+---
+'@keystone-next/keystone': patch
+---
+
+Moved the call to `createImagesContext` into `makeCreateContext()`.
diff --git a/packages-next/keystone/src/lib/createContext.ts b/packages-next/keystone/src/lib/createContext.ts
@@ -5,23 +5,25 @@ import type {
   KeystoneContext,
   KeystoneGraphQLAPI,
   BaseKeystone,
-  ImagesContext,
+  ImagesConfig,
 } from '@keystone-next/types';
 
 import { itemDbAPIForList, itemAPIForList, getArgsFactory } from './itemAPI';
 import { accessControlContext, skipAccessControlContext } from './createAccessControlContext';
+import { createImagesContext } from './createImagesContext';
 
 export function makeCreateContext({
   graphQLSchema,
   internalSchema,
   keystone,
-  images,
+  imagesConfig,
 }: {
   graphQLSchema: GraphQLSchema;
   internalSchema: GraphQLSchema;
   keystone: BaseKeystone;
-  images: ImagesContext | undefined;
+  imagesConfig?: ImagesConfig;
 }) {
+  const images = createImagesContext(imagesConfig);
   // We precompute these helpers here rather than every time createContext is called
   // because they require parsing the entire schema, which is potentially expensive.
   const publicGetArgsByList: Record<string, ReturnType<typeof getArgsFactory>> = {};

diff --git a/packages-next/keystone/src/lib/createSystem.ts b/packages-next/keystone/src/lib/createSystem.ts
@@ -3,7 +3,6 @@ import type { KeystoneConfig } from '@keystone-next/types';
 import { createGraphQLSchema } from './createGraphQLSchema';
 import { makeCreateContext } from './createContext';
 import { createKeystone } from './createKeystone';
-import { createImagesContext } from './createImagesContext';
 
 export function createSystem(config: KeystoneConfig, prismaClient?: any) {
   const keystone = createKeystone(config, prismaClient);
@@ -16,7 +15,7 @@ export function createSystem(config: KeystoneConfig, prismaClient?: any) {
     keystone,
     graphQLSchema,
     internalSchema,
-    images: createImagesContext(config.images),
+    imagesConfig: config.images,
   });
 
   return { keystone, graphQLSchema, createContext };