Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file stream #5592

Merged
merged 4 commits into from
May 3, 2021
Merged

Fix file stream #5592

merged 4 commits into from
May 3, 2021

Conversation

gwyneplaine
Copy link
Contributor

Don't manually pipe your stream like an idiot.
Use stream.pipeline instead.

Node 15 has a native promisified version of this function, but since we're not on 15, doing it manually.

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2021

🦋 Changeset detected

Latest commit: 241fd6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-next/keystone Patch
@keystone-next/test-utils-legacy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gwyneplaine gwyneplaine requested a review from a team May 3, 2021 06:09
@vercel
Copy link

vercel bot commented May 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/CUw8rT5eUeYV4UMSsJ9vBAbmtdQA
✅ Preview: https://keystone-next-docs-git-fix-file-stream-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview May 3, 2021 06:09 Inactive
@vercel vercel bot temporarily deployed to Preview May 3, 2021 06:12 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 241fd6a:

Sandbox Source
@keystone-next/example-sandbox Configuration

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@gwyneplaine gwyneplaine merged commit 1043243 into master May 3, 2021
@gwyneplaine gwyneplaine deleted the fix-file-stream branch May 3, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants