Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix withAuth when config.ui is undefined #5614

Merged
merged 2 commits into from
May 5, 2021
Merged

Conversation

timleslie
Copy link
Contributor

Previously you need to explicitly set ui: {} if you wanted the default Admin UI to work with the withAuth helper.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: d155b51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/DA91vMaf5VuTZvYzBkNRGbBVvpkE
✅ Preview: https://keystone-next-docs-git-fix-with-auth-ui-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d155b51:

Sandbox Source
@keystone-next/example-sandbox Configuration

@timleslie timleslie requested a review from a team May 5, 2021 02:52
@timleslie timleslie force-pushed the fix-with-auth-ui branch from 2e0c3b5 to 5cf114d Compare May 5, 2021 04:03
@vercel vercel bot temporarily deployed to Preview May 5, 2021 04:03 Inactive
@timleslie timleslie enabled auto-merge (squash) May 5, 2021 05:03
@vercel vercel bot temporarily deployed to Preview May 5, 2021 05:04 Inactive
@timleslie timleslie merged commit 4839322 into master May 5, 2021
@timleslie timleslie deleted the fix-with-auth-ui branch May 5, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants