Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update initialColumns default #5623

Merged
merged 1 commit into from
May 5, 2021
Merged

Update initialColumns default #5623

merged 1 commit into from
May 5, 2021

Conversation

timleslie
Copy link
Contributor

The comment on the types suggest we default to the first three columns. In practice we were defaulting to just the labelField, which was particularly unhelpful. This PR fixes this to have better defaults for the initial columns which match the comment on the types.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: 7a0ec6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/8muecgaKo49V2awEFpKqMdc6Sz47
✅ Preview: https://keystone-next-docs-git-sane-initial-columns-keystonejs.vercel.app

@timleslie timleslie requested a review from a team May 5, 2021 23:41
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a0ec6e:

Sandbox Source
@keystone-next/example-sandbox Configuration

@timleslie timleslie enabled auto-merge (squash) May 5, 2021 23:44
@timleslie timleslie merged commit b0a72a1 into master May 5, 2021
@timleslie timleslie deleted the sane-initial-columns branch May 5, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants