-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New core #5665
New core #5665
Conversation
🦋 Changeset detectedLatest commit: 420c025 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/4bcG7wJLiMQ8LWUbyhoNMhf7D94G |
…and use orderBy resolvers
* Add tests for uniqueness * Update packages-next/fields/src/types/timestamp/index.ts Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
Co-authored-by: Tim Leslie <timl@thinkmill.com.au>
/** | ||
* The label used for the list | ||
* @default listKey.replace(/([a-z])([A-Z])/g, '$1 $2').split(/\s|_|\-/).filter(i => i).map(upcase).join(' '); | ||
*/ | ||
// Not currently supported | ||
// label?: string; | ||
label?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we support these new config options now? If so we should make sure these are documented in schema.mdx
now before we forget about them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just removed support for them for now so we can make sure they're in the place we want them in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go! We've got a week until we ship, so we can clean up anything we find during the week. 🚀
This is a re-implemention of the core of Keystone and all the server-side parts of field types. The original intent was to land this along with all the changes mentioned in #5635 but to make this easier to land, we've instead made this only contain architectural changes (+ some minimal coupled breaking changes for practicality). We'll land the other changes mentioned #5635 in future PRs.