Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resolveFields #6789

Merged
merged 4 commits into from
Oct 14, 2021
Merged

Remove resolveFields #6789

merged 4 commits into from
Oct 14, 2021

Conversation

emmatown
Copy link
Member

This was deprecated quite a while ago and we even renamed context.lists to context.query while this was deprecated so I'd be surprised if many people are still using it.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2021

🦋 Changeset detected

Latest commit: 779b318

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@keystone-next/keystone Major
@keystone-next/example-assets-cloud Patch
@keystone-next/example-assets-local Patch
@keystone-next/example-auth Patch
@keystone-next/examples-app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-embedded-nextjs Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-blog Patch
@keystone-next/example-custom-admin-ui-logo Patch
@keystone-next/example-custom-admin-ui-navigation Patch
@keystone-next/example-custom-admin-ui-pages Patch
@keystone-next/example-custom-field-view Patch
@keystone-next/example-custom-field Patch
@keystone-next/example-default-values Patch
@keystone-next/example-document-field Patch
@keystone-next/example-extend-graphql-schema Patch
@keystone-next/example-json-field Patch
@keystone-next/example-rest-api Patch
@keystone-next/example-task-manager Patch
@keystone-next/example-testing Patch
@keystone-next/example-virtual-field Patch
@keystone-next/example-with-auth Patch
@keystone-next/auth Major
@keystone-next/cloudinary Major
@keystone-next/fields-document Major
@keystone-next/session-store-redis Major
@keystone-next/benchmarks-legacy Patch
@keystone-next/test-projects-basic Patch
@keystone-next/test-projects-crud-notifications Patch
@keystone-next/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/D24XYdPku2VBsGDtV1PsURNHqeXu
✅ Preview: https://keystone-next-docs-git-remove-resolve-fields-keystonejs.vercel.app

Co-authored-by: Tim Leslie <timl@thinkmill.com.au>
@vercel vercel bot temporarily deployed to Preview October 13, 2021 23:31 Inactive
@vercel vercel bot temporarily deployed to Preview October 13, 2021 23:33 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dcousens
dcousens previously approved these changes Oct 13, 2021
@vercel vercel bot temporarily deployed to Preview October 13, 2021 23:53 Inactive
@emmatown emmatown marked this pull request as ready for review October 13, 2021 23:55
@emmatown emmatown dismissed dcousens’s stale review October 13, 2021 23:56

Made a different small breaking change

@emmatown emmatown requested a review from a team October 13, 2021 23:57
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmatown emmatown merged commit d9e1ba8 into main Oct 14, 2021
@emmatown emmatown deleted the remove-resolve-fields branch October 14, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants