Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary types #6974

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Removing unnecessary types #6974

merged 3 commits into from
Nov 22, 2021

Conversation

JedWatson
Copy link
Member

Just noticed that on a fresh install, we get the following warnings in the console:

warning @keystone-next/auth > @keystone-ui/fields > @types/react-select@5.0.1: This is a stub types definition. react-select provides its own type definitions, so you do not need this installed.
warning @keystone-next/keystone > @keystone-ui/options > @types/react-select@5.0.1: This is a stub types definition. react-select provides its own type definitions, so you do not need this installed.
warning @keystone-next/keystone > @types/form-data@2.5.0: This is a stub types definition. form-data provides its own type definitions, so you do not need this installed.

I can vouch in particular for types being included in react-select@5.x so I've removed both dependencies.

@JedWatson JedWatson requested review from bladey and emmatown November 22, 2021 10:54
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2021

🦋 Changeset detected

Latest commit: b933971

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@keystone-ui/fields Patch
@keystone-ui/options Patch
@keystone-next/keystone Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/3Ee2VBdtVyQVi3nqcbeTgwUc8s86
✅ Preview: https://keystone-next-docs-git-remove-unnecessary-types-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview November 22, 2021 10:56 Inactive
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bladey bladey enabled auto-merge (squash) November 22, 2021 23:10
@bladey bladey merged commit 96fd2e2 into main Nov 22, 2021
@bladey bladey deleted the remove-unnecessary-types branch November 22, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants