Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index issues for document editor text-area and toolbar #7556

Merged
merged 2 commits into from
May 25, 2022

Conversation

Achisingh
Copy link
Contributor

@Achisingh Achisingh commented May 24, 2022

The document field toolbar that was over-lapping the Action Bar at the bottom (i.e. Save Changes, Delete Button) caused by z-index is fixed by using <Portal> instead. This also resolves z-index issues within the text-area (e.g. the popover for links in the document editor is now visible in the create modal). #6157 #7464

Co-authored-by: Mitchell Hamilton <mitchellhamilton@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

🦋 Changeset detected

Latest commit: 52fee89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystone-ui/modals Minor
@keystone-6/fields-document Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview May 25, 2022 at 0:27AM (UTC)

@Achisingh Achisingh changed the title Fix Fix z-index issues for document editor text-area and toolbar May 24, 2022
@vercel vercel bot temporarily deployed to Preview May 24, 2022 06:15 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Achisingh Achisingh force-pushed the document-editor-z-index branch from a4b097e to 52fee89 Compare May 25, 2022 00:25
@vercel vercel bot temporarily deployed to Preview May 25, 2022 00:27 Inactive
Copy link
Contributor

@gwyneplaine gwyneplaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants