Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrong resolveInput types until fixed #7801

Merged
merged 37 commits into from
Aug 18, 2022
Merged

Remove wrong resolveInput types until fixed #7801

merged 37 commits into from
Aug 18, 2022

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 16, 2022

This pull request removes the contextualised type for resolvedData in resolveInput, and it's return type.

In a followup change, will will be adding contextualised types back to this method, but as is, the types are misleading in different situations and may be providing a false sense of security about the safety of your code.

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 6:34AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: 92a8c51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-6/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 16, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 92a8c51:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview August 16, 2022 05:59 Inactive
@vercel vercel bot temporarily deployed to Preview August 17, 2022 02:45 Inactive
@vercel vercel bot temporarily deployed to Preview August 17, 2022 03:03 Inactive
@vercel vercel bot temporarily deployed to Preview August 17, 2022 05:48 Inactive
@vercel vercel bot temporarily deployed to Preview August 17, 2022 06:33 Inactive
@vercel vercel bot temporarily deployed to Preview August 17, 2022 08:01 Inactive
@dcousens dcousens marked this pull request as ready for review August 17, 2022 08:04
@vercel vercel bot temporarily deployed to Preview August 17, 2022 08:10 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 01:28 Inactive
dcousens and others added 3 commits August 18, 2022 11:40
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:15 Inactive
Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:17 Inactive
dcousens and others added 2 commits August 18, 2022 15:17
Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
Co-authored-by: Mitchell Hamilton <mitchell@hamil.town>
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:19 Inactive
@dcousens dcousens enabled auto-merge (squash) August 18, 2022 05:23
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:25 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:30 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 05:37 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 06:10 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 06:16 Inactive
@vercel vercel bot temporarily deployed to Preview August 18, 2022 06:34 Inactive
@dcousens dcousens merged commit 0261a5e into main Aug 18, 2022
@dcousens dcousens deleted the refine-fieldhooks branch August 18, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants