-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change view module resolution #7805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emmatown
force-pushed
the
change-view-resolution
branch
from
August 17, 2022 06:30
ffc7032
to
3164eb9
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d358281:
|
This was referenced Aug 18, 2022
dcousens
force-pushed
the
change-view-resolution
branch
from
August 25, 2022 01:28
3164eb9
to
86460ce
Compare
dcousens
reviewed
Aug 25, 2022
dcousens
force-pushed
the
change-view-resolution
branch
from
August 25, 2022 01:47
5f07b9b
to
368583b
Compare
dcousens
approved these changes
Aug 25, 2022
dcousens
reviewed
Aug 25, 2022
dcousens
force-pushed
the
change-view-resolution
branch
from
August 25, 2022 02:16
0563ef4
to
d358281
Compare
Merged
dcousens
added a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com> Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes field type
.views
resolution from being path based to a module path.This means instead of using
require.resolve(...)
to resolve your custom views, you will now use a path as though it was resolving from wherekeystone dev
is run.This additionally means you can use typical modules or packages without needing relative or absolute pathing workarounds.
For example, if you wanted to use the
@keystone-6
text field views for your custom field type, you can now do that through canonical module resolution: