Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable skipLibCheck #7828

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Disable skipLibCheck #7828

merged 1 commit into from
Aug 23, 2022

Conversation

emmatown
Copy link
Member

Given we generate .d.ts files and there are frequently problems with them, skipLibCheck means we either don't see the issues or we see the symptoms of issues while not seeing that the actual problem is with a .d.ts file. skipLibCheck was enabled by #7786 because TypeScript doesn't like one of Markdoc's .d.ts files. I've used patch-package to change the .d.ts file to something that TS seems okay with.

(I haven't opened an issue on Markdoc because it seems like the issue is more to do with TypeScript and I haven't reduced the problem down yet)

@emmatown emmatown requested a review from a team August 23, 2022 00:16
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

⚠️ No Changeset found

Latest commit: 18d1f15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 0:16AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18d1f15:

Sandbox Source
@keystone-6/sandbox Configuration

@emmatown emmatown merged commit 7c71411 into main Aug 23, 2022
@emmatown emmatown deleted the disable-skip-lib-check branch August 23, 2022 01:43
dcousens pushed a commit that referenced this pull request Sep 14, 2022
dcousens pushed a commit that referenced this pull request Sep 15, 2022
dcousens pushed a commit that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants