Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we generate
.d.ts
files and there are frequently problems with them,skipLibCheck
means we either don't see the issues or we see the symptoms of issues while not seeing that the actual problem is with a .d.ts file.skipLibCheck
was enabled by #7786 because TypeScript doesn't like one of Markdoc's.d.ts
files. I've used patch-package to change the.d.ts
file to something that TS seems okay with.(I haven't opened an issue on Markdoc because it seems like the issue is more to do with TypeScript and I haven't reduced the problem down yet)