-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rate limiting in CI #7875
Fix rate limiting in CI #7875
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50ef018:
|
What a pain, but I understand |
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
I think this should fix the rate limiting we're seeing because if you look at the logs, it always fails in
actions/setup-node
right after it logsAttempt to resolve LTS alias from manifest...
(https://github.com/actions/setup-node/blob/c2dfe2df9884bf1033e0ee352d86309105ea6cf0/src/installer.ts#L44) that leads to https://github.com/actions/toolkit/blob/500d0b42fee2552ae9eeb5933091fe2fbf14e72d/packages/tool-cache/src/tool-cache.ts#L589 which does a GitHub API call so getting a rate limit error from GitHub makes sense.So I think we can fix it by writing a version rather than use
lts/*
, from a cursory reading of the code inactions/setup-node
doesn't try to do a call to GitHub's API when using a version range like16
. Updating our CI every time there is a new active Node LTS seems fine.