Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydration warning on docs site #7921

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

emmatown
Copy link
Member

This fixes the hydration warning from React on the website, it was caused by the toasts. I haven't liked the toasts on the website for a while anyway because they don't feel very websitey so I just replaced them with:

  • On the homepage with the copy button for yarn create keystone-app, the copy icon turns into a check icon for a second after copying
  • On the links on headings, I just removed the copying behavior so clicking the link is just a link to the heading and nothing more which is what sites generally do

@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 3:35AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2022

⚠️ No Changeset found

Latest commit: 364d72e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 364d72e:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview September 13, 2022 03:35 Inactive
@emmatown emmatown marked this pull request as ready for review September 13, 2022 03:51
@emmatown emmatown requested a review from a team September 13, 2022 03:51
@emmatown emmatown merged commit 7aac32c into main Sep 13, 2022
@emmatown emmatown deleted the fix-hydration-warning-on-website branch September 13, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants