Fix bigInt deserialisation #8005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4da0159:
|
emmatown
reviewed
Oct 17, 2022
emmatown
approved these changes
Oct 17, 2022
dcousens
added a commit
that referenced
this pull request
Oct 17, 2022
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
bigIntis not parsed early, it will throw when trying to format the value in the view.This is checked as an error condition, but the branch throwing in lieu of this is throwing when trying to
JSON.stringifyaBigInt.This pull request resolves the lack of parsing in the deserialisation (bug 1) and in the event an error condition does occur, this pull request fixes the error message by not using
JSON.stringify, instead showing only thetypeofvalue types that were involved.