Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to next ^13 #8061

Merged
merged 15 commits into from
Nov 24, 2022
Merged

Upgrade to next ^13 #8061

merged 15 commits into from
Nov 24, 2022

Conversation

AliceRossa
Copy link
Contributor

Updated Next.js dependency to ^13.0.1

@changeset-bot

This comment was marked as resolved.

@vercel
Copy link

vercel bot commented Nov 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 4:02AM (UTC)

@vercel vercel bot temporarily deployed to Preview November 2, 2022 18:18 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fba6840:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview November 2, 2022 18:27 Inactive
@dcousens
Copy link
Member

dcousens commented Nov 3, 2022

Hi @AliceRossa, thanks for the pull request!

Could you please remove the unrelated formatting changes?
Additionally can you revert the changes you made to the live-reloading tests, which should intentionally fail.

@AliceRossa AliceRossa closed this Nov 3, 2022
@vercel vercel bot temporarily deployed to Preview November 3, 2022 10:28 Inactive
@AliceRossa AliceRossa reopened this Nov 3, 2022
@vercel vercel bot temporarily deployed to Preview November 3, 2022 10:41 Inactive
@AliceRossa
Copy link
Contributor Author

AliceRossa commented Nov 3, 2022

Hi @AliceRossa, thanks for the pull request!

Could you please remove the unrelated formatting changes? Additionally can you revert the changes you made to the live-reloading tests, which should intentionally fail.

It is a pleasure to collaborate on this project!
What unrelated formatting changes are you referring to? Changes on the <Link> Component and the <a> tag are related to the update to Next.js 13.

@vercel vercel bot temporarily deployed to Preview November 3, 2022 22:30 Inactive
@Industrial
Copy link

Thanks for this! Eagerly awaiting the update so I can use it with Next.js 13 :-)

Very happy to see the Keystone CMS community be so pro-active. I was about to open a ticket for this, but there's already a PR!

@dcousens
Copy link
Member

Changes on the Component and the tag are related to the update to Next.js 13.

Apologies @AliceRossa, I should have checked the diff more carefully 🤦‍♂️
Thanks for reverting the test changes 💛

@dcousens dcousens changed the title Next.js 13 Upgrade Upgrade to next ^13 Nov 11, 2022
@vercel vercel bot temporarily deployed to Preview November 11, 2022 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview November 11, 2022 15:30 Inactive
@Industrial
Copy link

Industrial commented Nov 11, 2022

Hi. I'm trying to use @AliceRossa 's branch in my Next.js project with yarn link but getting version mismatches of react (hook error, using ^18.2.0) and of graphql (same version, ^16.6.0). I'm not sure how to do it correctly :-)

I can't seem to join the Keystone Slack. It requires a keystone email address

@vercel vercel bot temporarily deployed to Preview November 12, 2022 20:15 Inactive
@dcousens
Copy link
Member

dcousens commented Nov 13, 2022

Thanks @AliceRossa for continuing work on this, I'm approving ✔️ CI runs where I can

@AliceRossa
Copy link
Contributor Author

I don't understand how to fix CI, I never modified this test file. Is it possible to help me?

@dcousens dcousens self-assigned this Nov 18, 2022
@vercel vercel bot temporarily deployed to Preview November 19, 2022 13:47 Inactive
@dcousens dcousens assigned emmatown and unassigned dcousens Nov 22, 2022
@vercel vercel bot temporarily deployed to Preview November 23, 2022 04:04 Inactive
@vercel vercel bot temporarily deployed to Preview November 23, 2022 21:58 Inactive
@vercel vercel bot temporarily deployed to Preview November 24, 2022 03:55 Inactive
@vercel vercel bot temporarily deployed to Preview November 24, 2022 04:02 Inactive
@dcousens dcousens enabled auto-merge (squash) November 24, 2022 04:44
@dcousens dcousens merged commit 5989672 into keystonejs:main Nov 24, 2022
@dcousens
Copy link
Member

dcousens commented Nov 24, 2022

Thanks for your help @AliceRossa , this wouldn't have happened for quite a few weeks without your contributions 🎉🥳

@AliceRossa AliceRossa deleted the Next.js-13 branch December 7, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants