-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of dependencies #8790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
force-pushed
the
less-deps
branch
3 times, most recently
from
August 30, 2023 01:57
d772785
to
1356a10
Compare
dcousens
commented
Aug 30, 2023
dcousens
force-pushed
the
less-deps
branch
2 times, most recently
from
August 30, 2023 02:00
5238611
to
2ef5740
Compare
dcousens
changed the title
Reduce number of dependencies
Reduce number of dependencies, remove resolved workaround
Aug 30, 2023
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e22925:
|
borisno2
approved these changes
Aug 30, 2023
dcousens
force-pushed
the
less-deps
branch
3 times, most recently
from
August 30, 2023 10:20
c747a3d
to
8df03e1
Compare
dcousens
commented
Aug 30, 2023
dcousens
changed the title
Reduce number of dependencies, remove resolved workaround
Reduce number of dependencies
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, this pull request reduces the number of dependencies used by
packages/core/
and ourtests/
.A number of listed dependencies were unused, only used for development, or otherwise probably unnecessary.