Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit TypeInfo types for examples with getContext #9016

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

dcousens
Copy link
Member

Resolves the comment from @mmachatschek in #8876 (comment) that our usecase- examples didn't use TypeInfo, which left the seed-data examples using the unrefined context.

@dcousens
Copy link
Member Author

We should probably use config<TypeInfo> in every example...

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb429cb:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens mentioned this pull request Feb 12, 2024
@dcousens dcousens merged commit c8e790a into main Feb 12, 2024
58 checks passed
@dcousens dcousens deleted the context-types branch February 12, 2024 00:53
@dcousens dcousens mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant