Update tests for atomicity, prefer /tmp, and add new access control tests #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
force-pushed
the
fix-test-atomicity
branch
9 times, most recently
from
54d3616 to
f7dcd54
Compare
dcousens
force-pushed
the
fix-test-atomicity
branch
5 times, most recently
from
1970d86 to
a5b9b66
Compare
Co-authored-by: ChrisLaneAU <43688949+ChrisLaneAU@users.noreply.github.com>
Co-authored-by: ChrisLaneAU <43688949+ChrisLaneAU@users.noreply.github.com>
dcousens
force-pushed
the
fix-test-atomicity
branch
from
a7948b6 to
36d787c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates our tests to be atomic by design, by not sharing temporary directories or other resources.
Additionally, this pull request adds new access control tests to verbosely test as many of the possible code paths as we can.
For many moons the tests have been using
--runInBandto sidestep a number of problems in relation to concurrency and databases sharing resources. This pull request should fix that problem by using:Thanks to @ChrisLaneAU for help with early work on this