Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated hooks #9204

Open
wants to merge 61 commits into
base: v-next
Choose a base branch
from
Open

Remove deprecated hooks #9204

wants to merge 61 commits into from

Conversation

gautamsi
Copy link
Member

@gautamsi gautamsi commented Jul 8, 2024 •
edited
Loading

This replaces all the hooks from original combined form with the granular one inline with #9056 #9057 #8826

this cleans up the code and is breaking changes.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 8, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a54a00:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens
Copy link
Member

dcousens commented Jul 8, 2024 •
edited
Loading

I'll be merging #9166 ASAP, which should help with this pull request, fwiw

@gautamsi gautamsi mentioned this pull request Jul 8, 2024
Merged
@gautamsi
Copy link
Member Author

gautamsi commented Jul 8, 2024 •
edited
Loading

If we go the way of this PR, #9166 would not be needed I think.

This should be part of v-next branch so that it can take longer, you should merge #9166

@gautamsi gautamsi changed the base branch from main to v-next July 8, 2024 05:10
@gautamsi gautamsi force-pushed the operation-fields-hooks branch 2 times, most recently from 73b2403 to e2f6ad3 Compare July 18, 2024 01:55
@gautamsi gautamsi marked this pull request as ready for review July 18, 2024 02:11
@gautamsi gautamsi changed the title [WIP] Remove deprecated hooks Remove deprecated hooks Jul 18, 2024
@gautamsi gautamsi changed the base branch from v-next to main July 18, 2024 14:53
@gautamsi gautamsi changed the base branch from main to v-next July 18, 2024 14:53
renovate bot and others added 5 commits July 23, 2024 10:46
@renovate
fix(deps): update emotion monorepo (keystonejs#9223)
a56b6e2 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update pnpm to v9.6.0 (keystonejs#9222)
7df0c58 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@simonswiss @dcousens
Change docs/ to use nextjs app router (keystonejs#9220)
d46c311 
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@simonswiss
Fix static pages generation (keystonejs#9227)
9ff170a
@simonswiss @dcousens
Use metadatabase instead of manually passing the siteBaseUrl to O…
a37cf27 
…G and Twitter images (keystonejs#9228)

Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@gautamsi
Copy link
Member Author

@dcousens I am done with this, are you able to take a look and help resolve single type error in lint and documentation.

@gautamsi gautamsi mentioned this pull request Jul 25, 2024
Merged
@gautamsi
Copy link
Member Author

I have created documentation in separate PR #9231

@gautamsi gautamsi mentioned this pull request Jul 29, 2024
Open
15 tasks
renovate bot and others added 5 commits July 30, 2024 09:15
@renovate
fix(deps): update dependency @emotion/cache to v11.13.1 (keystonejs#9242
fe7e468 
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@simonswiss @dcousens
Keystaticification 🚀 of docs/ (keystonejs#9202)
f07b12f 
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@dcousens
Fix Astro and Remix examples not building (keystonejs#9247)
048b36d
@renovate
chore(deps): lock file maintenance (keystonejs#9221)
eb1b0a3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dcousens
Remove getGqlNames function from frontend, prefer the meta query (k…
73a9132 
…eystonejs#9249)
dcousens and others added 16 commits August 14, 2024 09:50
@dcousens @iamandrewluca
Fix schemas for create-keystone-app (keystonejs#9275)
855bc25 
Co-authored-by: Andrei Luca <1881266+iamandrewluca@users.noreply.github.com>
@simonswiss @dcousens
Add new blog post for last year of releases (keystonejs#9268)
c25a5c2
@DavidMulder0 @dcousens
Fix telemetry disable command (keystonejs#9289)
830d46d 
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (keystonejs#9295)
3a70b7f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update mariadb docker tag to v11.5 (keystonejs#9297)
9d16f9a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update pnpm to v9.7.1 (keystonejs#9296)
a2e2c7a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dcousens
Add keystone telemetry inform command and update telemetry policy (k…
19a734c 
…eystonejs#9292)
@dcousens
Inline prismaClientPath for examples/ (keystonejs#9300)
7dda360
@dcousens
Fix transaction passthrough types, and add linting for examples (keys…
2a6033f 
…tonejs#9301)
@dcousens
Update CodeSandbox versions, and fix prisma client paths for `example…
40e85b7 
…s/` (continuation of keystonejs#9300) (keystonejs#9302)
@acburdine @dcousens
Fix validation hook merge function passthrough (keystonejs#9278)
dc3802a 
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@simonswiss
Add buttondown for the /docs newsletter subscription using server a…
6e5b50d 
…ctions 😎 (keystonejs#9293)
@renovate
fix(deps): update dependency slate-react to ^0.109.0 (keystonejs#9308)
a791237 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update pnpm to v9.9.0 (keystonejs#9306)
a1fbb1b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @dcousens
fix(deps): update dependency slate-history to ^0.109.0 (keystonejs#9307)
722839c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@renovate
chore(deps): lock file maintenance (keystonejs#9305)
1ddd41b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot and others added 12 commits August 28, 2024 08:59
@renovate @dcousens
fix(deps): update prisma monorepo to v5.19.0 (keystonejs#9310)
c61ac79 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@dcousens
Use ms for jest timeouts (keystonejs#9311)
5b8a3c7
@dcousens
Fix esbuild example package name
0c850e4
@dcousens
Version Packages (keystonejs#9312)
12fb38b
@dcousens
Remove pre-built schemas from create-keystone-app (keystonejs#9314)
616907e
@dcousens
Version Packages (CKA) (keystonejs#9317)
c29510f
@renovate
chore(deps): lock file maintenance (keystonejs#9319)
f399e45 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update prisma monorepo to v5.19.1 (keystonejs#9321)
4f8f925 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@kennedybaird
Fix input value for Decimal validate hook (keystonejs#9262)
d543e60
@benderham @dcousens
Update link to Keystone Enterprise (keystonejs#9320)
7808e7d 
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@renovate
fix(deps): update dependency slate-react to ^0.110.0 (keystonejs#9322)
a8a3913 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@gautamsi
remove types for deprecated hooks
7a54a00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens left review comments

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gautamsi @dcousens @simonswiss @kennedybaird @acburdine @DavidMulder0 @benderham