Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list.ui.hide* functionality #9217

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix list.ui.hide* functionality #9217

merged 2 commits into from
Jul 17, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Jul 17, 2024

Resolves #9216
Thanks to @tv42 for reporting this and proposing a fix.

@dcousens dcousens self-assigned this Jul 17, 2024
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit affda48:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens added the 🐛 bug Unresolved bug label Jul 17, 2024
@dcousens dcousens merged commit 5ee45ae into main Jul 17, 2024
42 of 43 checks passed
@dcousens dcousens deleted the fix-hide-ui branch July 17, 2024 01:20
@dcousens
Copy link
Member Author

dcousens commented Jul 17, 2024

Arguably having ui.hideCreate and graphql.omit.create is silly.
As is, you can force ui.hideCreate: false and graphql.omit.create: true, and you'll have a broken create button in the admin.

Maybe the type should be graphql.omit.create: true | false | 'ui' or something.

Thoughts @tv42?

@dcousens dcousens mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unresolved bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui.hideCreate and ui.hideDelete don't work when graphql.omit.create and graphql.omit.delete are set
1 participant