Change docs/ to use nextjs app router
#9220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
changed the title
dcousens
changed the title
docs/ pages to app router migration
dcousens
changed the title
docs/ pages to app router migrationdocs/ to use nextjs app router
simonswiss
force-pushed
the
pages-to-app-router
branch
2 times, most recently
from
6ea9c20
to
ba2d7cd
Compare
simonswiss
force-pushed
the
pages-to-app-router
branch
from
ba2d7cd
to
218f97a
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64a381d:
|
|
Maybe this PR causes 404 error on docs? |
|
Whoops yes — I fixed the poorly ported over |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the entire keystonejs.com website to the Next.js
approuter.It's a pretty big PR with a lot of moving parts — but it's going to make the integration of Keystatic (particularly data fetching at the leaf components rather than passed down from pages) much nicer.
Things the PR covers:
metadataSEO tags, replacing theOgcomponentIt will need a thorough review by someone who is very familiar with the website. I checked out all the pages, the SEO metadata is working, the theme switcher is working — most things look good to me, but someone with more affinity with the site should have a good look around :)