Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction passthrough types, and add linting for examples #9301

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 20, 2024

#9280 introduced prismaTypes to .keystone/types, but Prisma is a namespace, not a type.

I don't have the capacity to fix this canonically right now, thus I have inlined the isolationLevel type, and added a target for CI tests to catch this in future.

../auth/node_modules/.keystone/types.ts:172:40 - error TS2694: Namespace '"/home/keystone/workspace/keystone/examples/auth/node_modules/myprisma/index"' has no exported member 'Prisma'.

172   prismaTypes: import('./../myprisma').Prisma
                                           ~~~~~~

Found 53 errors in 53 files.

Errors  Files
     ...
     1  ../auth/node_modules/.keystone/types.ts:137
     ...

@acburdine if you wanted to follow this up with a fix, I'm happy to revert this 💛

@dcousens dcousens changed the title Fix prismaTypes linting for examples Fix transaction passthrough types, and add linting for examples Aug 20, 2024
@dcousens dcousens added the 🐛 bug Unresolved bug label Aug 20, 2024
@keystonejs keystonejs deleted a comment from codesandbox-ci bot Aug 20, 2024
@dcousens dcousens force-pushed the fix-tsc branch 2 times, most recently from 360f3ba to 524406d Compare August 20, 2024 06:59
@dcousens dcousens merged commit 2a6033f into main Aug 20, 2024
31 of 53 checks passed
@dcousens dcousens deleted the fix-tsc branch August 20, 2024 07:00
@dcousens dcousens mentioned this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Unresolved bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant