Programmatic Changelog Checking, Github

[nfuden]

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

Changleog validation is a nice to have. Ideally its something that can be inspected and dealt with in github itself.

Describe the solution you'd like

Implement a changelog check in github actions.
ideally something like this that checks if there is a correct semver scoped issue for the branch in question

Additional Context

previously pre donation solo-io had a bot that would handle these events

Note that this is both part of #10363 and #10217

[yuval-k]

If the bot is not involved fixing the changelog folder, ideally we shouldn't require a folder. maybe take an approach like in istio, where all release notes go in one folder?
or Envoy, where post-release the changelogs are organized into folders?

[nfuden]

I really dont like the envoy strategy.
The fact that the last commit to a changelog is always the "rename" one makes git blame alot more painful.

That being said would be interested to chat more on the desired format.

[yuval-k]

we discussed in slack but to summarize here - i don't care about the format; but rather the devex of moving the changloge file to the right folder mid-PR

[ashishb-solo]

@nfuden git blame has an --ignore-rev flag that can ignore certain commits when blaming a file. I'm not sure how well it works if the file was renamed though. It's mostly used for ignoring commits that reformat files or whitespace changes, etc.

[nfuden]

Yeah but I like the basic vscode integration for lens

[ilrudie]

+1 to @yuval-k's comment. Having to move the changelog entry around mid-pr is not great. If we get a chance to begin again I'd definitely like to go with something that avoids having to deal with those moves.

[timflannagan]

I threw up a WIP enhancement for adopt k/k's style of changelog mangement: #10381. There are other alternatives to explore, but this felt like a reasonable balance.

[lgadban]

For the initial 2.0.0 release, we will rely on handcrafted release notes and look to implement the automated approach post-release