Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerates Code from Repo Rename #10355

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Nov 15, 2024

Regenerates code from running ci/check-generated-code.sh script due to repo rename.

Fixes #10354

Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@nfuden
Copy link
Contributor

nfuden commented Nov 15, 2024

Whoo
image
thanks for getting this name change ci green!

@danehans
Copy link
Contributor Author

The gateway api conformance tests CI job is failing due to:

    --- FAIL: TestConformance/HTTPRouteServiceTypes (1.18s)
        --- PASS: TestConformance/HTTPRouteServiceTypes/2_request_to_'/headless'_should_go_to_infra-backend-v1 (0.01s)
        --- FAIL: TestConformance/HTTPRouteServiceTypes/0_request_to_'/manual-endpointslices'_should_go_to_infra-backend-v1 (30.00s)
        --- FAIL: TestConformance/HTTPRouteServiceTypes/1_request_to_'/headless-manual-endpointslices'_should_go_to_infra-backend-v1 (30.00s)

I'm unable to reproduce this failure locally:

$ gateway-api git:(heads/v1.1.0) ✗ go test -v ./conformance -run TestConformance -args \
    --gateway-class=gloo-gateway \
    --supported-features=HTTPRouteServiceTypes \
--conformance-profiles=GATEWAY-HTTP
...
   --- PASS: TestConformance/HTTPRouteServiceTypes (1.17s)
        --- PASS: TestConformance/HTTPRouteServiceTypes/1_request_to_'/headless-manual-endpointslices'_should_go_to_infra-backend-v1 (0.03s)
        --- PASS: TestConformance/HTTPRouteServiceTypes/0_request_to_'/manual-endpointslices'_should_go_to_infra-backend-v1 (0.03s)
        --- PASS: TestConformance/HTTPRouteServiceTypes/2_request_to_'/headless'_should_go_to_infra-backend-v1 (0.03s)
...
PASS
ok  	sigs.k8s.io/gateway-api/conformance	70.099s

I am rerunning the job.

@danehans danehans merged commit 131af7e into kgateway-dev:main Nov 15, 2024
17 checks passed
@danehans danehans deleted the 10354 branch November 15, 2024 17:31
stevenctl pushed a commit to stevenctl/gloo that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static Code Analysis / Generated Code CI Job is Failing
3 participants