Bootstrap initial kgateway helm chart #10470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
changed the title
jenshu
reviewed
Jan 17, 2025
| - `values.yaml`: default configuration values for the chart | ||
|
|
||
| Check the [Gloo Edge docs](https://docs.solo.io/gloo-edge/latest/installation/) | ||
| Check the [K8s Gateway docs](https://docs.solo.io/k8s-gateway/latest/installation/) |
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.0 |
There was a problem hiding this comment.
do we want 0.0.1? do we need to keep this in sync with the kgateway release version?
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "1.16.0" |
There was a problem hiding this comment.
do we need appVersion? how will it differ from version?
| @@ -0,0 +1,22 @@ | |||
| 1. Get the application URL by running these commands: | |||
| {{- else -}} | ||
| apiVersion: extensions/v1beta1 | ||
| {{- end }} | ||
| kind: Ingress |
| @@ -0,0 +1,28 @@ | |||
| {{- if .Values.autoscaling.enabled }} | |||
| apiVersion: autoscaling/v2beta1 | |||
| kind: HorizontalPodAutoscaler | |||
There was a problem hiding this comment.
do we need HPA for the control plane? afaik gloo only had that for the proxies but not control plane
| @@ -0,0 +1,15 @@ | |||
| apiVersion: v1 | |||
| kind: Pod | |||
| @@ -0,0 +1,32 @@ | |||
| --- | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRole | |||
There was a problem hiding this comment.
was a corresponding ClusterRoleBinding also generated?
|
@jenshu I was going to rip out the non-helm-generated bits that aren't relevant here (e.g. ingress) in a follow-up, but I can do that here if you prefer. |
jenshu
approved these changes
Jan 17, 2025
timflannagan
added a commit
to timflannagan/kgateway
that referenced
this pull request
Jan 21, 2025
This commit is a follow-up to kgateway-dev#10443 and kgateway-dev#10470 and migrates away from the quay.io/solo-io container image registry in favor of the ghcr.io repository in the project. Additional work around renaming the gloo component, binaries, etc. will be handled once we're closing the finish line with the Signed-off-by: timflannagan <timflannagan@gmail.com>
This was referenced Jan 21, 2025
tiberiuac
pushed a commit
to openet/gloo
that referenced
this pull request
Feb 13, 2025
…ateway-dev#10470) (kgateway-dev#10496) Backports 1bed380 from main Signed-off-by: Shashank Ram <shashank.ram@solo.io>
stevenctl
pushed a commit
to stevenctl/gloo
that referenced
this pull request
Feb 17, 2025
…ateway-dev#10470) (kgateway-dev#10497) Backports 1bed380 from main. Signed-off-by: Shashank Ram <shashank.ram@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces an initial install/helm/kgateway chart via the
helm createbootstrap command and updates the gateway2 codegen bash script to generate CRDs and RBAC for this chart along with the legacy chart. Note: this chart is not functional at this point. Future PRs will iterate on this effort, expand this chart values & templates, make sure it can be deployed correctly, passes the conformance suite, etc.In the short term, the plan is to migrate away from the legacy chart + publish this chart with goreleaser to GHCR.io before we cut our first release in this new project.
Related to #10443.
Initial task for the #10423 tracker.
Checklist: