Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Remove unused targets #10564

Merged

Conversation

timflannagan
Copy link
Member

@timflannagan timflannagan commented Jan 31, 2025

Description

This PR is a series of commits that remove unused/stale/broken Makefile targets after the recent round of cleanup adventures in this project. See each chunked commit for more information.

Related to #10496.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Signed-off-by: timflannagan <timflannagan@gmail.com>
This repository no longer has githooks checked in

Signed-off-by: timflannagan <timflannagan@gmail.com>
This was an artifact of the previous release workflow and no longer needed with the goreleaser-powered workflow

Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Comment on lines -14 to -22
## Kubernetes e2e test resource example generation tool

This tool generates the input resources defined in code as an output yaml file. You can find an example under `test/kubernetes/e2e/features/headless_svc/generate/generate_examples.go`.

These examples are run as part of the codegen, but can also be manually run using the following command:

```bash
go generate <path to the generate.go file>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may still need this part

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can move this into a test/kubernetes/e2e readme

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I assumed this was cruft since there wasn't any non-changelog tools checked into the devel/tools path.

@jenshu jenshu added this pull request to the merge queue Jan 31, 2025
Merged via the queue into kgateway-dev:main with commit 40c277d Jan 31, 2025
8 checks passed
@timflannagan timflannagan deleted the chore/purge-unused-make-targets branch January 31, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants