-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode kgateway service name #10666
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jenny Shu <jenny.shu@solo.io>
Signed-off-by: Jenny Shu <jenny.shu@solo.io>
Signed-off-by: Jenny Shu <jenny.shu@solo.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove the fullnameOverride
value for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we fix this the other way around?
i.e. add the service name as an env-var in the deployment, and use that for the xds host?
for reference, what i'm suggesting is to add an env var in the kgateway deployment:
and use that in GetControlPlaneXdsHost func GetControlPlaneXdsHost() string {
return kubeutils.ServiceFQDN(metav1.ObjectMeta{
Name: os.Getenv("XDS_HOST"),
Namespace: namespaces.GetPodNamespace(),
})
} We may want to tweak this, so we centralize our processing of env-vars. |
Adding on to @yuval-k 's last point, the existing "settings" processing is centralized here currently: https://github.com/kgateway-dev/kgateway/blob/main/internal/kgateway/extensions2/settings/settings.go#L7-L12 This was intended to be as lightweight as possible while still providing a standardized approach. In general though, we may want to reevaluate this approach given that the controller binary is now ran via cobra. Viper is fairly idiomatic and allows to define configuration in a single place and demotes the env-var specifics to an implementation detail. |
Since our controller makes an assumption about the control plane service being named
kgateway
we should hardcode this in the helm chart for now.Also removed "gloo" references from some constants.
Fixes #10659