-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Envoy gloo bump for inja escaped characters #8499
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit 68096ed): https://gloo-edge--pr8499-envoy-gloo-bump-for-43ptaome.web.app (expires Thu, 03 Aug 2023 21:01:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
docs/content/guides/traffic_management/request_processing/transformations/_index.md
Outdated
Show resolved
Hide resolved
docs/content/guides/traffic_management/request_processing/transformations/_index.md
Outdated
Show resolved
Hide resolved
projects/gloo/api/external/envoy/extensions/transformation/transformation.proto
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should allow for inheritance either via a gateway or settings level default
…loo into envoy-gloo-bump-for-inja
…loo into envoy-gloo-bump-for-inja
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[]*envoytransformation.TransformationTemplate_HeaderToAppend, | ||
len(inTemplate.GetHeadersToAppend())) | ||
headers := inTemplate.GetHeadersToAppend() | ||
for i := range headers { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for i, hdr := range headers is more idiomatic and only an extra allocation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's one allocation, but it copies the slice val out to the temp on every loop iteration
Description
This gets the latest envoy-gloo in order to test functionality with new Inja feature and new custom callback
Control plane changes to accommodate this new functionality:
Settings CRD:
TransformationStages:
Setting can be configured as part of
stagedTransformations
on VirtualHostOptions, RouteOptions, or WeightedDestinationOptionsContext
See context here
Checklist:
make -B install-go-tools generated-code
to ensure there will be no code diff